Az.service fabric preview #25124
Open
Az.service fabric preview #25124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sfmc_2023_12_01_preview
… sfmc_2023_12_01_preview
… sfmc_2023_12_01_preview
… sfmc_2023_12_01_preview
… sfmc_2023_12_01_preview
… sfmc_2023_12_01_preview
… sfmc_2023_12_01_preview
… sfmc_2023_12_01_preview
… sfmc_2023_12_01_preview
… sfmc_2023_12_01_preview
… sfmc_2023_12_01_preview
… sfmc_2023_12_01_preview
️✔️Az.Accounts
️✔️Az.ServiceFabric
️✔️Az.ServiceFabricManagedClusters
|
|
@mwesigwaguma Please target this PR to https://github.com/Azure/azure-powershell/tree/Az.ServiceFabric-preview. And fix the generation SDK issue. |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
… Az.ServiceFabric-preview
NoriZC
reviewed
Jun 17, 2024
| @@ -24,22 +24,22 @@ public PSManagedNodeType(NodeType nodeType) | |||
| type: nodeType.Type, | |||
| tags: nodeType.Tags, | |||
| isPrimary: nodeType.IsPrimary, | |||
| vmInstanceCount: nodeType.VmInstanceCount, | |||
| dataDiskSizeGB: nodeType.DataDiskSizeGB, | |||
| vmInstanceCount: nodeType.VMInstanceCount, | |||
There was a problem hiding this comment.
Seems this property is changing, which might cause a breaking change. Could you please help confirm whether this will affect cx?
"Az.ServiceFabric","Microsoft.Azure.Commands.ServiceFabric.Commands.AddAzureRmServiceFabricClientCertificate","Add-AzServiceFabricClientCertificate","0","3010","The property 'VmInstanceCount' of type 'Microsoft.Azure.Management.ServiceFabric.Models.NodeTypeDescription' has been removed.","Add the property 'VmInstanceCount' back to type 'Microsoft.Azure.Management.ServiceFabric.Models.NodeTypeDescription'."
There was a problem hiding this comment.
should not affect how the command is ran or the output. The property nodeType.VMInstanceCount is the internal property which is assigned to vmInstanceCount which is what is actually returned in output
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NoriZC
previously approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.