refactor(dpg): remove unnecessary Creatable property
#4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archerzz
requested review from
m-nash,
lirenhe,
ArthurMa1978,
hallipr and
JoshLove-msft
as code owners
This is a prerequisite of Azure#3994 `Creatable` is not used in generator. See: - `TypeSpecInputClientConverter`: https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Common/Input/InputTypes/Serialization/TypeSpecInputClientConverter.cs - `InputClient`: https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Common/Input/InputTypes/InputClient.cs Let's remove it.
archerzz
force-pushed
the
emitter/remove-creatable-property
branch
from
1c7ae6d
to
0167e73
Compare
|
preview pr is Azure/azure-sdk-for-net#44670 There is no code change. |
ArcturusZhang
approved these changes
Jun 27, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
|
OK this commit fixes the dependency issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a prerequisite of #3994
Creatableis not used in generator. See:TypeSpecInputClientConverter: https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Common/Input/InputTypes/Serialization/TypeSpecInputClientConverter.csInputClient: https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Common/Input/InputTypes/InputClient.csLet's remove it.
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?