Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Bug-4717: Citation Panel] proving borders and resize of the content without overlap. #1051

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

Rohini-Microsoft
Copy link
Contributor

Purpose

By providing borders to the fields.
Resize of the content without overlap.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

1. High contrast modes
Open CWYD URL.
Go to system setting ->Accessibility->Contrast themes->select aquatic in drop down-> apply.
Go to CWYD URL, you can find the screen, does not have border, so there is no separation between citation panel and other section.

2. Resizing: Text in the page should be adaptable to resizing up to 200% zoom in 1280p without overlap.
Open CWYD URL.
Go to system setting ->System->Display resolution->select 1280P in drop down-> apply.
Go to CWYD URL, zoom it to 200%, you can find the screen the content overlapping, and conversation area is not visible.

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Please find attached screenshot for reference

image

image

Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL250256177% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
278 0 💤 0 ❌ 0 🔥 33.543s ⏱️

@adamdougal adamdougal added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 284a4b2 Jun 18, 2024
9 checks passed
@adamdougal adamdougal deleted the PSL-BUG-4717 branch June 18, 2024 15:08
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants