fix: Correctly set computer vision location #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This was causing the deployment to fail when advanced image processing was enabled as it overrides the default location in the `main.bicep` to '' - Tried adding the same logic to the `main.bicepparam` file but it clashes with the validation in the `main.bicep`
Coverage Report •
|
|
Would this work? @description('Location of Computer Vision Resource (if useAdvancedImageProcessing=true)')
@allowed([
// List taken from https://learn.microsoft.com/en-us/azure/ai-services/computer-vision/how-to/image-retrieval?tabs=python#prerequisites
'eastus'
'westus'
'koreacentral'
'francecentral'
'northeurope'
'westeurope'
'southeastasia'
''
])
param computerVisionLocation string = ''
...
module computerVision 'core/ai/cognitiveservices.bicep' = if (useAdvancedImageProcessing) {
name: 'computerVision'
scope: rg
params: {
name: computerVisionName
kind: 'ComputerVision'
location: computerVisionLocation != '' ? computerVisionLocation : location
tags: tags
sku: {
name: computerVisionSkuName
}
}
} |
adamdougal
changed the title
|
@cecheta Great suggestion! That appears to work perfectly. Might be worth turning off whitespace in the review tab as it looks like my IDE auto formatted the files |
Pre-commit should be formatting the files, but looks like you're using an old version of bicep |
cecheta
approved these changes
Jun 18, 2024
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was enabled as it overrides the default location in the
main.bicepto
""