Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Legal Assistant configuration #1007

Merged
merged 97 commits into from
Jun 24, 2024
Merged

feat: Legal Assistant configuration #1007

merged 97 commits into from
Jun 24, 2024

Conversation

Fr4nc3
Copy link
Contributor

@Fr4nc3 Fr4nc3 commented May 30, 2024

Here's the detailed information for the Pull Request:

Purpose

  • Introduce the Legal Assistant feature to the Chat With Your Data (CWYD) platform. This feature includes:
    • Legal documents sample data to help test and demonstrate the legal assistant capabilities.
    • An admin dropdown to select either the default prompt or the legal assistant prompt for specific use cases.
    • A comprehensive README for the Legal Assistant, detailing its purpose, how to update prompt configurations, and question and answer examples.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
# Run the application and navigate to the admin panel to select the Legal Assistant prompt
# Upload sample legal documents and test various queries as per the README guidelines
# Verify the responses are accurate and formatted correctly as per the enhanced prompt

What to Check

Verify that the following are valid:

  • The admin dropdown for selecting the Legal Assistant prompt is functional.
  • The Legal Assistant responds correctly to the example questions provided in the README.
  • The document listings, summaries, and specific clause extractions are accurate and properly formatted.
  • The enhanced prompt handles state, business type, date range, and other criteria correctly.
  • Ensure the citation format is correctly followed and duplicates are removed.

Other Information

  • Ensure that the Legal Assistant README is detailed enough for new users to understand the setup and functionality without external guidance.
  • Double-check the integration with the existing CWYD framework to ensure no conflicts or performance issues.

Fr4nc3 and others added 30 commits May 22, 2024 14:36
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ontend (Azure-Samples#944)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ross Smith <[email protected]>
…Azure-Samples#943)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…zure-Samples#945)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ross Smith <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ross Smith <[email protected]>
…mples#950)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ross-p-smith
Copy link
Collaborator

Hi @Fr4nc3 - this PR looks like it is failing as the Code Coverage decreases because of it - maybe write some tests around the new method you added in the Config Helper?

Copy link
Collaborator

@hunterjam hunterjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fr4nc3 @aldunson - Please address the requested changes in the PR and resubmit.

.gitignore Outdated Show resolved Hide resolved
code/backend/pages/04_Configuration.py Outdated Show resolved Hide resolved
docs/legal_assistance.md Show resolved Hide resolved
docs/legal_assistance.md Outdated Show resolved Hide resolved
docs/legal_assistance.md Show resolved Hide resolved
docs/legal_assistance.md Outdated Show resolved Hide resolved
docs/legal_assistance.md Outdated Show resolved Hide resolved
@hunterjam
Copy link
Collaborator

@Fr4nc3 @aldunson - The updates are looking better. However, I am unable to receive a valid response within the chat interface. I reviewed the logs and found this error. I verified that all of the endpoints and keys are correct. I deployed this solution multiple times therefore, it is repeatable.
image

docs/legal_assistance.md Outdated Show resolved Hide resolved
docs/legal_assistance.md Show resolved Hide resolved
Copy link
Collaborator

@hunterjam hunterjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldunson - You removed the Azure OpenAI Model. The feedback was to add Azure OpenAI Model Name.

docs/legal_assistance.md Show resolved Hide resolved
@hunterjam hunterjam added this pull request to the merge queue Jun 24, 2024
Merged via the queue into Azure-Samples:main with commit 64088d8 Jun 24, 2024
6 checks passed
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants