Persistent streams #3030
Persistent streams #3030
Conversation
…e event based. notify server when there is an error on a segment.
…fter a close request wait for segments to complete the active batch on stopping the application
| @@ -1206,6 +1213,14 @@ public void setEventStoreConfiguration(EventStoreConfiguration eventStoreConfigu | |||
| this.eventStoreConfiguration = eventStoreConfiguration; | |||
| } | |||
|
|
|||
| public int getPersistentStreamThreads() { | |||
| return persistentStreamThreads; | ||
| } | ||
|
|
||
| public void setPersistentStreamThreads(int persistentStreamThreads) { |
| persistentStreamHolder.set(null); | ||
| if (throwable != null) { | ||
| logger.info("{}: Rescheduling persistent stream", streamId, throwable); | ||
| scheduler.schedule(this::start, 1, TimeUnit.SECONDS); |
There was a problem hiding this comment.
Maybe this would be better with an incremental time? A lot of applications at the same time might be able to bring Axon Server down, keeping it going in circles?
| } | ||
| return metaDataValues; | ||
| } | ||
| if ("SequentialPolicy".equals(settings.getSequencingPolicy())) { |
There was a problem hiding this comment.
I think this is correct, but it does mean we should be weary of the combination of sequential policy with the dead letter queue, as it could fill up quickly.
| } | ||
|
|
||
| @Test | ||
| void open() { |
There was a problem hiding this comment.
I would prefer a clearer test name, maybe something like canOpenStreamAndProcessTwoEvents or something similar.
| @@ -71,7 +71,7 @@ | |||
| ${project.basedir}/../coverage-report/target/site/jacoco-aggregate/jacoco.xml | |||
| </sonar.coverage.jacoco.xmlReportPaths> | |||
| <!-- Axon Server --> | |||
| <axonserver-connector-java.version>2023.2.0</axonserver-connector-java.version> | |||
| <axonserver-connector-java.version>2024.0.0-SNAPSHOT</axonserver-connector-java.version> | |||
There was a problem hiding this comment.
We should remember to put in a released version, at the latest before releasing 4.10 of framework. Ideally through it's better to change it to the released version as soon as it's available, still in this pr.
There was a problem hiding this comment.
The release plugin will automatically detect and resolve dependencies pointing at snapshots.
| this(eventProcessorProperties, null, deadLetterQueueProvider); | ||
| } | ||
|
|
||
| public DeadLetterQueueProviderConfigurerModule( |
exponential backoff for retrying failed connection to axon server
Depends on AxonIQ/axonserver-connector-java#347 to be merged.