fix: maximized window optimization #5622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
on macOS and Linux, wouldn't it remember the maximized window? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've stopped saving the size of the window when it has been maximized, this means that when closing the application on Linux and MacOS from a maximized state, the application will open in it's previously regular state and size.
For Windows, I've added the previous maximized state to persistence, and maximize the window if it was previously maximized on application launch. This seems to be the standard behavior for Windows applications.
Relates: #3287
Closes: #2904 - PS. This is for windows only, applications on MacOS when closed will turn to regular state, so it cannot open maximized.
PR Checklist