Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npo.nl #182166

Closed
wants to merge 1 commit into from
Closed

Fix npo.nl #182166

wants to merge 1 commit into from

Conversation

EchoDev
Copy link

@EchoDev EchoDev commented Jun 24, 2024

This fixes the pre-roll adds shown on npo.nl

This can possibly work for other npo.nl related sites but are not tested.

@@ -4,6 +4,7 @@
! Good: example.org###rek; ||example.com/ads/
! Bad: example.org#@##banner_ad (for instance, should be in allowlist.txt or in antiadblock.txt)
!
||azurewebsites.net^$domain=npo.nl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's about ad like reported here - #166205
If so, it's already fixed by a scriptlet and I cannot reproduce it, though it might be useful for platforms which do not support scriptlets.
I guess that azurewebsites.net might be used for other purposes than ad as well, so could this rule be more "ad related"?
For example:

||azurewebsites.net/*adslot$domain=npo.nl

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scriptlet did not work for me on Firefox with uBlock Origin (all latest version).

azurewebsites.net is only used for tracking and serving ads from the network connections I saw, I noticed no breakage on the site itself

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, azurewebsites.net can be used for other content as well.
Even though it doesn't break anything, I still prefer more specific rule(s), at least for now.

@Alex-302
Copy link
Member

@Alex-302 Alex-302 closed this Jun 28, 2024
Alex-302 added a commit that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants