Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Create Azure/Language provider and connect it to LP Service #399

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cadic
Copy link

@cadic cadic commented Feb 27, 2023

Description of the Change

Adds Azure/Language provider within LanguageProcessing service

The API keys screen is in Classifai > Language Processing > Microsoft Azure.

The provider will have 2 types of requests:

  1. Sync request returns the result immediately in run time. Used for Key Phrase Extraction
  2. Async request sets up the job, which results to be requested later. Will be used for Abstractive Summarization

The API version is currently 2022-10-01-preview.

The Abstractive Summarization feature is not available publicly and needs to be applied for before we proceed with it.

Closes #159

How to test the Change

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul
Copy link
Member

jeffpaul commented Mar 9, 2023

@cadic might be good to possibly build off the work @dkotter has in his OpenAI/ChatGPT PR to add this functionality and focus more on ensuring someone can select either OpenAI or Azure for this feature.

@jeffpaul jeffpaul added this to the 2.0.0 milestone Mar 14, 2023
@jeffpaul
Copy link
Member

FYI that I would still like to see this get out of WIP as this would be a good UX experiment for how we handle the same functionality within the plugin via two different service providers. I might be more pressed to handle this when we have a specific request to have a different service provider for this functionality, it may be best to leave as WIP for now.

In discussion with @dkotter, it may also be better holding on this PR until Azure brings this feature out of beta preview into general public availability.

@jeffpaul jeffpaul modified the milestones: 2.0.0, Future Release Mar 20, 2023
@jeffpaul jeffpaul added needs:engineering This requires engineering to resolve. needs:refresh This requires a refreshed PR to resolve. help wanted Extra attention is needed labels Apr 10, 2023
@jeffpaul
Copy link
Member

jeffpaul commented Jan 2, 2024

@Sidsector9 this might be a good PR to pick up (or perhaps close and open a subsequent related one) to use as an example of adding a new service provider with the v3 release; thoughts?

@Sidsector9
Copy link
Member

Since we're adding this to core, it would be a good example for internal developers only. Third-party devs will still need to use hooks that will ship out with v3.

@jeffpaul
Copy link
Member

jeffpaul commented Jan 4, 2024

@Sidsector9 sorry, I had intended for this to be built post-v3 stabilizing in develop (or even released) so that the PR here (or one like it if we want to start anew) could be an example of how to extend ClassifAI post-v3's hooks being available.

Copy link

github-actions bot commented Feb 5, 2024

@cadic thanks for the PR! Could you please rebase your PR on top of the latest changes in the base branch?

@jeffpaul jeffpaul modified the milestones: Future Release, 3.1.0 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs:engineering This requires engineering to resolve. needs:refresh This requires a refreshed PR to resolve.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-populate missing meta tags and descriptions
3 participants