Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Attribute QuoteType Behavior vs InternalQuoteType fixes #552, #516 #554

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

POFerro
Copy link
Contributor

@POFerro POFerro commented Jun 21, 2024

Hi :),

I just faced an issue where adhoc created attributes where allways being quoted SingleQuote despite having QuoteType set to DoubleQuote as described in #552
When looking at the code I realized some inconsistencies in the behavior of InternalQuoteType vs QuoteType.
As such here is my proposed behavior for these properties:

  1. InternalQuoteType is the QuoteType inferred by the system when reading the document or on Value set ( ex: Value being set for atribute with WithoutValue )
  2. QuoteType is the value set by the user that overrides the Internal calculated value, except if the value is being set to Initial wich rolls back the QuoteType to the internal value

With this behavior I believe we can have a consistent and intuitive way of handling quotes in attributes
All public behavior of the classes was kept untouched so there should not be any breaking change ( ex: Global setting in the document still overrides any of these attributes )

Please consider this change since I believe it fixes #552 and #516 and makes attribute quoting much more intuitive.

Thanks and best regards
POFerro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Creating empty value for attributte
1 participant