scroll: Set tabIndex to -1 for simplebar content wrapper. #30444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulipbot
added
size: XL
area: left sidebar (ui)
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: web/src/scroll_util.ts
Did you find this useful? React with a 👍 or 👎 |
shubham-padia
changed the title
|
@andersk can you review this one? |
shubham-padia
force-pushed
the
simplebar-tabindex
branch
from
6c4d556
to
35c5b20
Compare
andersk
approved these changes
Jun 18, 2024
shubham-padia
force-pushed
the
simplebar-tabindex
branch
from
35c5b20
to
042bb8d
Compare
We need this update to configure tabIndex for simplebar.
shubham-padia
force-pushed
the
simplebar-tabindex
branch
from
042bb8d
to
bb4c929
Compare
shubham-padia
added
the
integration review
Fixes zulip#30403. Having tabIndex set to 0 led to keyboard focus being put on a scrollbar container, which led to users having to tab twice to skip a container. This commit also removes instances of tabIndex being set to -1 programatically for certain cases, since it is -1 by default now. This commit also removes `outline: none` for simplebar since that property is not needed anymore because the wrapper is not focusable anymore.
shubham-padia
force-pushed
the
simplebar-tabindex
branch
from
bb4c929
to
fe11f3b
Compare
|
Merged, thanks @shubham-padia and @andersk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30403.
Having tabIndex set to 0 led to keyboard focus being put on a scrollbar container, which led to users having to tab twice to skip a container. This commit also removes instances of tabIndex being set to -1 programatically for certain cases, since it is -1 by default now. This commit also removes
outline: nonefor simplebar since that property is not needed anymore becuase the wrapper is not focusable anymore.The option became configurable in Grsmto/simplebar#695
The second commit is technically large, but I think all those changes belong together. Removing the previous hacks and css along with adding the property in the same commit made more sense to me. Reviewing it should be manage-able considering most of it just adding the tab-index property. Let me know if you think it should be split up
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: