Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No outline on keyboard navigation for clear_search_button #30402

Open
shubham-padia opened this issue Jun 12, 2024 · 1 comment
Open

No outline on keyboard navigation for clear_search_button #30402

shubham-padia opened this issue Jun 12, 2024 · 1 comment

Comments

@shubham-padia
Copy link
Member

One example of this can be found in the channel filter where pressing Tab while being focused in the input area will give no visual feedback. But the keyboard navigation is right now on the clear search button, if you press enter, you'll see that the input has been cleared. We should fix this in all instances of this button being used.

CZO thread

@shubham-padia
Copy link
Member Author

From a preliminary investigation, just removing outline: none !important will not be enough for the solution. While it will bring back the blue border, the blue border looks different and wonky in some cases, e.g. Right sidebar user filter, the css will need to be refactored at those places one by one, before we remove outline none !important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants