Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info_density: Blockers on the road to testing for the 9.0 release. #30359

Closed
16 tasks done
karlstolley opened this issue Jun 7, 2024 · 2 comments
Closed
16 tasks done
Assignees
Labels
area: information density Rendering and UI related to adjustable font-size, line-height in progress redesign Part of the webapp redesign project, including blockers. umbrella list Checklist of issues for a project/goal

Comments

@karlstolley
Copy link
Contributor

karlstolley commented Jun 7, 2024

This is a list of all blocking issues that need to be addressed in order to begin wider testing of 16/140 information density (as there will certainly be other issues caught in that phase; these are just the most obvious ones).

Non-blocking issues are being tracked in #30476

Bugs

  • Database-stored line-heights not getting picked up when toggling dense mode

Navbar

  • Correct size of text in Search box, including placeholder (search results list looks great at 16/140, but probably needs more checking)

Left sidebar

  • Correct for too-tight spacing between DM unread and usernames (E.g., in the DM area, “Prospero from The Tempest” hugs way tight to 1 when there’s an unread DM from him.)

Views

Inbox

  • Remove font-size: 15px on .inbox-container

Recent conversations view

  • DM-related icons (envelope; status circle; group) are anemically small and need to be adjustable
  • The unread sort icon becomes misaligned with unreads: CZO discussion; this is an issue at legacy sizes, too.

Message rows

  • Allow timestamps to size larger >> convert existing value to ems
  • Don't resize EDITED/MOVED markers for now; no space

Compose box

  • Collapsed compose box has a larger New direct message button than reply button container
  • Both the dropdown at the topic marker container have height values set to var(--compose-recipient-box-min-height), which is a precise pixel value that may be unnecessary
  • Banners have their own font-size and line height (15px, 18px) hard-coded in; and there are some layout things tied to those (e.g., the max-height: 36px on .main-view-banner-action-button comes from two 18px line-heights)

Organization settings

  • Lock links move to second line on 16/140; need a flex rewrite in there
  • Under Organization profile, the “Preview organization” button looks screwy (might look screwy at legacy sizes, too; check i18n)

Help modal

Pills

  • Pills have a bunch of pixel-specific values set on them. Those at the very least need to be expressed as ems at 14px (coordinate with @evykassirer)
  • Pills are a problem under the Create channel portion of the Channel settings modal
@karlstolley karlstolley added the area: information density Rendering and UI related to adjustable font-size, line-height label Jun 7, 2024
@karlstolley karlstolley self-assigned this Jun 7, 2024
@alya alya added the redesign Part of the webapp redesign project, including blockers. label Jun 7, 2024
@zulipbot
Copy link
Member

zulipbot commented Jun 7, 2024

Hello @zulip/design members, this issue was labeled with the "redesign" label, so you may want to check it out!

@karlstolley
Copy link
Contributor Author

Blockers here have all been addressed. Remaining work leading to 9.0 is being tracked in #30476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: information density Rendering and UI related to adjustable font-size, line-height in progress redesign Part of the webapp redesign project, including blockers. umbrella list Checklist of issues for a project/goal
Projects
Status: Done
Development

No branches or pull requests

3 participants