Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the Deactivated users panel, align filters better in narrow windows #30353

Open
alya opened this issue Jun 7, 2024 · 6 comments
Open

In the Deactivated users panel, align filters better in narrow windows #30353

alya opened this issue Jun 7, 2024 · 6 comments

Comments

@alya
Copy link
Contributor

alya commented Jun 7, 2024

In the Deactivated users table, when the filters don't fit next to the headings, we should:

  • Put them on the left below the heading.
  • Leave more horizontal space between the filters and the table. We might need less vertical space between the heading and the filters.

Screenshot 2024-06-07 at 09 55 58@2x

The same might apply to other settings panels (perhaps in other languages), but "Deactivated users" is a long heading, so it's easy to see the issue there.

We should probably wait on this PR to merge to avoid conflicts:

@zulipbot
Copy link
Member

zulipbot commented Jun 7, 2024

Hello @zulip/server-settings members, this issue was labeled with the "area: settings UI" label, so you may want to check it out!

@timabbott
Copy link
Sponsor Member

#29894 might be related and worth fixing along with this.

@amenu4aie2
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Jun 9, 2024

Welcome to Zulip, @amenu4aie2! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@userAdityaa
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

@userAdityaa This issue cannot be claimed, as someone else is already working on it. Please see our contributor guide for advice on finding an issue to work on. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants