Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Views label for spectators #30324

Closed
alya opened this issue Jun 5, 2024 · 4 comments · Fixed by #30443
Closed

Add Views label for spectators #30324

alya opened this issue Jun 5, 2024 · 4 comments · Fixed by #30443
Assignees
Labels
area: left sidebar (ui) Left sidebar buttons/interactions excluding popovers area: public access Issues related to logged-out access in Zulip help wanted in progress

Comments

@alya
Copy link
Contributor

alya commented Jun 5, 2024

To make the UI consistent, we should have a Views label for spectators in the left sidebar. Since we just have two views right now, it doesn't need to be collapsible.

Screenshot 2024-06-05 at 11 23 43

@alya alya added help wanted area: public access Issues related to logged-out access in Zulip area: left sidebar (ui) Left sidebar buttons/interactions excluding popovers labels Jun 5, 2024
@suryaanshrai
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Jun 7, 2024

Welcome to Zulip, @suryaanshrai! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@opmkumar
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

@opmkumar This issue cannot be claimed, as someone else is already working on it. Please see our contributor guide for advice on finding an issue to work on. Thanks!

opmkumar added a commit to opmkumar/zulip that referenced this issue Jun 16, 2024
opmkumar added a commit to opmkumar/zulip that referenced this issue Jun 18, 2024
opmkumar added a commit to opmkumar/zulip that referenced this issue Jun 18, 2024
opmkumar added a commit to opmkumar/zulip that referenced this issue Jun 18, 2024
opmkumar added a commit to opmkumar/zulip that referenced this issue Jun 18, 2024
timabbott pushed a commit to opmkumar/zulip that referenced this issue Jun 18, 2024
We don't include the toggle functionality, to avoid needing to design
what a collapsed Views thing would look like.

Fixes zulip#30324.
timabbott pushed a commit that referenced this issue Jun 18, 2024
We don't include the toggle functionality, to avoid needing to design
what a collapsed Views thing would look like.

Fixes #30324.
opmkumar added a commit to opmkumar/zulip that referenced this issue Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: left sidebar (ui) Left sidebar buttons/interactions excluding popovers area: public access Issues related to logged-out access in Zulip help wanted in progress
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants