Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is:dm search suggestion for spectators #30320

Closed
alya opened this issue Jun 5, 2024 · 3 comments · Fixed by #30330
Closed

Remove is:dm search suggestion for spectators #30320

alya opened this issue Jun 5, 2024 · 3 comments · Fixed by #30330
Assignees
Labels

Comments

@alya
Copy link
Contributor

alya commented Jun 5, 2024

Typing is: in the search bar shows the following suggestion for spectators:

Screenshot 2024-06-05 at 10 59 28

Since spectators do not have DMs, we should remove it, as we do for is:starred, etc.

@alya alya added bug help wanted area: search area: public access Issues related to logged-out access in Zulip labels Jun 5, 2024
@zulipbot
Copy link
Member

zulipbot commented Jun 5, 2024

Hello @zulip/server-search members, this issue was labeled with the "area: search" label, so you may want to check it out!

@joyhchen
Copy link
Collaborator

joyhchen commented Jun 6, 2024

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Jun 6, 2024

Welcome to Zulip, @joyhchen! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants