Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement automatic theme switcher for spectators #30318

Open
alya opened this issue Jun 5, 2024 · 1 comment · May be fixed by #30334
Open

Implement automatic theme switcher for spectators #30318

alya opened this issue Jun 5, 2024 · 1 comment · May be fixed by #30334
Assignees
@sayamsamal
Labels
area: public access Issues related to logged-out access in Zulip help wanted in progress priority: high

Comments

@alya
Copy link
Contributor

alya commented Jun 5, 2024 •
edited
Loading

Now that we have a nice 3-way theme switcher widget, we should use it for spectators as well, replacing the "Switch do dark theme" / Switch to light theme" option.

We might want to try placing it just above "Select language" rather than below, if that looks better.

Screenshot 2024-06-05 at 10 50 45
@alya alya added help wanted priority: high area: public access Issues related to logged-out access in Zulip labels Jun 5, 2024
@alya
Copy link
Contributor Author

alya commented Jun 5, 2024

@sayamsamal is this a quick one for you while the code is fresh in mind?

sayamsamal added a commit to sayamsamal/zulip that referenced this issue Jun 6, 2024
@sayamsamal
gear_menu: Add theme switcher to the gear menu popover.
2a01464 
Standardize theme selection across the web app by replacing separate
light/dark theme menu options being used in the spectator view with the
unified theme switcher.

Fixes zulip#30318.
sayamsamal added a commit to sayamsamal/zulip that referenced this issue Jun 6, 2024
@sayamsamal
gear_menu: Add theme switcher to the gear menu popover.
d54c01c 
Standardize theme selection across the web app by replacing separate
light/dark theme menu options being used in the spectator view with the
new 3-way theme switcher.

Fixes zulip#30318.
@sayamsamal sayamsamal linked a pull request Jun 6, 2024 that will close this issue
Open
12 tasks
sayamsamal added a commit to sayamsamal/zulip that referenced this issue Jun 10, 2024
@sayamsamal
gear_menu: Add theme switcher to the gear menu popover.
a05f1fe 
Standardize theme selection across the web app by replacing separate
light/dark theme menu options being used in the spectator view with the
new 3-way theme switcher.

Fixes zulip#30318.
sayamsamal added a commit to sayamsamal/zulip that referenced this issue Jun 20, 2024
@sayamsamal
gear_menu: Add theme switcher to the gear menu popover.
523a75d 
Standardize theme selection across the web app by replacing separate
light/dark theme menu options being used in the spectator view with the
new 3-way theme switcher.

Fixes zulip#30318.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sayamsamal sayamsamal

Labels
area: public access Issues related to logged-out access in Zulip help wanted in progress priority: high
Projects
Zulip 9.0 priorities
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gear_menu: Add theme switcher to the gear menu popover. sayamsamal/zulip
3 participants
@alya @zulipbot @sayamsamal