Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visual/push notifications for edited messages #30316

Open
3 tasks
alya opened this issue Jun 5, 2024 · 0 comments
Open
3 tasks

Fix visual/push notifications for edited messages #30316

alya opened this issue Jun 5, 2024 · 0 comments

Comments

@alya
Copy link
Contributor

alya commented Jun 5, 2024

As discussed in CZO thread and #26166 (comment), we should fix the following visual/push notification quirks for edited messages:

  • Editing a message does not re-rerender either desktop or mobile push notifications that are currently visible.
  • Editing a message to remove a mention does not revoke desktop or mobile push notifications either.
  • Editing a message to delete all its content works the same as any other edit.

We should also update /help/edit-a-message.md#message-notifications once we've fixed the above.

Note that this issue used to be part of #26584. We're splitting it out as this part is much more complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant