Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto populate bot avatar for webhook integrations bot #30139

Open
6 tasks
PieterCK opened this issue May 20, 2024 · 9 comments
Open
6 tasks

Auto populate bot avatar for webhook integrations bot #30139

PieterCK opened this issue May 20, 2024 · 9 comments
Labels

Comments

@PieterCK
Copy link
Collaborator

PieterCK commented May 20, 2024

🗒️ Overview

This proposal aims to enhance the bot avatar feature by automatically assigning a bot avatar to incoming webhook bots based on the integration app they are associated with.
This feature was originally discussed in:
Issue #692
PR #12474

CZO discussion: here

Save the integration field to BotConfigData.

  • To start, add another "Select an integration" dropdown field to the bot creation modal (add_new_bot_form.hbs).
  • Save the selected integration from the bot creation modal using BotConfigData probably in the same manner as how Embedded bots save their service_name.

Make integration field update-able in Backend.

  • Pre-populated the original "Select an integration" field in the generate URL integration modal (generate_integration_url_modal.hbs) with the selected option during bot creation.
  • Every time "Select an integration" field change, make calls to the backend to change the value in BotConfigData. A good reference mightbe over at Settings where we save on field change instead of clicking a "save" button somewhere.

Auto Assign Bot Avatar

  • Auto-assign bot avatar to incoming webhook bots with the selected integration. This could be done in endpoints such as add_bot_backend() to auto-assign the bot avatar when the bot is created. There may be better ways this could be achieved

mock-up of the new bot creation modal:

Before After
image Screenshot from 2024-05-06 14-00-15
image pre-populated when opened image

Follow up

  • The second "Select an integration" dropdown field in the generate URL integration modal could be removed. This step will need to be confirmed again once the proposed changes have been implemented. CZO discussion
@PieterCK
Copy link
Collaborator Author

@zulipbot add "area: bots"

@zulipbot
Copy link
Member

zulipbot commented May 24, 2024

Hello @zulip/server-bots, @zulip/server-integrations members, this issue was labeled with the "area: integrations", "area: bots" labels, so you may want to check it out!

@Mukul1235
Copy link
Collaborator

I would like to work on this issue

@Mukul1235
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @Mukul1235, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@Mukul1235
Copy link
Collaborator

Hello @Mukul1235, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

I had completed the work on that issue. this issue is ready for maintainer review

@PieterCK
Copy link
Collaborator Author

PieterCK commented Jun 20, 2024

Hello Mukul, thanks for picking up this issue. You might want to catch up on the discussion in the CZO if you haven't already. There were some small details I haven't updated in the issue description. I'll update it in a moment

@PieterCK
Copy link
Collaborator Author

PieterCK commented Jun 20, 2024

Updated PR description.

This issues' scope is quiet wide. I think it might be a good idea to start your PR by only addressing the first couple of point first..

Feel free to ask in the discussion at CZO if you have any questions,

@Mukul1235
Copy link
Collaborator

Hello @PieterCK
yeah sure..thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants