Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xCluster] DDL Replication - Pass producer table ids during creates to link tables #23013

Open
hulien22 opened this issue Jun 25, 2024 · 0 comments
Open

[xCluster] DDL Replication - Pass producer table ids during creates to link tables #23013

hulien22 opened this issue Jun 25, 2024 · 0 comments
Assignees
@hulien22
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue xCluster Label for xCluster related issues/improvements
Projects
xCluster DDL Replication

Comments

@hulien22
Copy link
Contributor

hulien22 commented Jun 25, 2024 •
edited by jira bot
Loading

Jira Link: DB-11942
Currently we just use table names to match tables, but this doesn't work if there are table renames, or if a table is dropped then recreated (duplicate tables with the same name).

We should get the producer table id from the source and pass that through to the target.
@hulien22 hulien22 added area/docdb YugabyteDB core features xCluster Label for xCluster related issues/improvements labels Jun 25, 2024
@hulien22 hulien22 self-assigned this Jun 25, 2024
@hulien22 hulien22 added this to To do in xCluster DDL Replication via automation Jun 25, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Jun 25, 2024
hulien22 added a commit that referenced this issue Jun 26, 2024
@hulien22
[#23013] xClusterDDLRepl: Allow table_ids for GetXClusterStreams
f2e574e 
Summary:
As part of using table_ids for xCluster DDL Replication to match tables together, we need to be able
to request streams by producer table ids as well. This will be used in add_table_to_target_task in a
follow-up diff (D35874).

**Upgrade/Rollback safety:**
Only adding in new proto fields
Jira: DB-11942

Test Plan:
```
ybd --cxx-test xcluster_outbound_replication_group-itest --gtest_filter "XClusterOutboundReplicationGroupTest.TestGetStreamByTableId"
```

Reviewers: hsunder, xCluster

Reviewed By: hsunder

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D36136
jasonyb pushed a commit that referenced this issue Jun 27, 2024
@hari90 @jaki
[pg15] Bulk port from master to pg15-cherrypicks - 34
a57b2c7 
Summary:
 411a32e [DB-11813] Rename ysql_conn_mgr_idle_or_pending_clients metric name
 c2e13ef [#15682] YSQL: Fix stack_is_too_deep function in ASAN
 ef31455 [PLAT-14188] Fixing upgrade disk availability check
 db6b1b7 [#23004] YCQL: Fix tserver crash due to NULL pointer dereference
 0ada80a [PLAT-14433] Use correct kubeconfig for edit provider validation
 eccbc10 [PLAT-14414] Enable Kubernetes provider validation by default
 199f679 [PLAT-14324]: Move all node agent based flags from BETA to INTERNAL in Provider Conf keys file
 86a865d [PLAT-14443] YBA Installer wait for ready time configurable.
 ac184a8 [#22882] YSQL: Fix deadlock in DDL atomicity
 a4218fb [Docs] Sort feature to tables (Where fulfills the criteria) (#22836)
 2f267ca [#22996] xCluster: Add SOURCE_UNREACHABLE and SYSTEM_ERROR enums

Skipped due to conflict:
dee7691 [#21534] docdb: Set owner correctly for cloned databases
34632ba [PLAT-14495] Set up the node_exporter for ynp
7c99ff9 [#22876][#22773] CDCSDK: Add new yb-admin command to remove user table from CDCSDK stream
4e9a81c [#22876][#22835][#22773] CDCSDK: Remove non-eligible tables for CDC from existing CDCSDK stream
f2e574e [#23013] xClusterDDLRepl: Allow table_ids for GetXClusterStreams

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: tfoucher, sanketh, jenkins-bot

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D36184
hulien22 added a commit that referenced this issue Jun 28, 2024
@hulien22
[BACKPORT pg15-cherrypicks][#23013] xClusterDDLRepl: Allow table_ids …
4b1dd4a 
…for GetXClusterStreams

Summary:
Original commit: f2e574e / D36136
As part of using table_ids for xCluster DDL Replication to match tables together, we need to be able
to request streams by producer table ids as well. This will be used in add_table_to_target_task in a
follow-up diff (D35874).

**Upgrade/Rollback safety:**
Only adding in new proto fields
Jira: DB-11942

Test Plan:
```
ybd --cxx-test xcluster_outbound_replication_group-itest --gtest_filter "XClusterOutboundReplicationGroupTest.TestGetStreamByTableId"
```

Reviewers: hsunder, xCluster, jason

Reviewed By: jason

Subscribers: ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hulien22 hulien22

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue xCluster Label for xCluster related issues/improvements
Projects
xCluster DDL Replication
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @hulien22