Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xCluster] Add enum to identify Network and System errors in GetReplicationStatus #22996

Closed
1 task done
hari90 opened this issue Jun 25, 2024 · 0 comments
Closed
1 task done
Assignees
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@hari90
Copy link
Contributor

hari90 commented Jun 25, 2024

Jira Link: DB-11919

Description

Add two new enums NETWORK_ERROR, and SYSTEM_ERROR. NETWORK_ERROR is reported if the Poller (xCluster Target) cannot communicate with the Producer (xCluster Source). SYSTEM_ERROR is reported if the Poller encounters an other error.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@hari90 hari90 added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Jun 25, 2024
@hari90 hari90 self-assigned this Jun 25, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Jun 25, 2024
@hari90 hari90 changed the title [xCluster] Add enum to identify Network and System errors [xCluster] Add enum to identify Network and System errors in GetReplicationStatus Jun 25, 2024
@hari90 hari90 closed this as completed in 2f267ca Jun 26, 2024
hari90 added a commit that referenced this issue Jun 26, 2024
…_ERROR enums

Summary:
Original commit: 2f267ca / D36097
Prior to this change the Poller only reports certain types of errors. This change adds two new enums `SOURCE_UNREACHABLE`, and `SYSTEM_ERROR`. `SOURCE_UNREACHABLE` is reported if the Poller (xCluster Target) cannot communicate with the Producer (xCluster Source). `SYSTEM_ERROR` is reported if the Poller encounters an other error.

**Upgrade/Rollback safety:**
New enum values are in-memory only. They are sent from tserver to master. Since master is always upgraded before the tserver and rolled back after the tserver rollback this is safe to upgrade and rollback.

Fixes #22996
Jira: DB-11919

Test Plan:
XClusterTest, NetworkReplicationError
XClusterTest, ApplyReplicationError

Reviewers: jhe, slingam, xCluster

Reviewed By: slingam

Subscribers: ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36183
jasonyb pushed a commit that referenced this issue Jun 27, 2024
Summary:
 411a32e [DB-11813] Rename ysql_conn_mgr_idle_or_pending_clients metric name
 c2e13ef [#15682] YSQL: Fix stack_is_too_deep function in ASAN
 ef31455 [PLAT-14188] Fixing upgrade disk availability check
 db6b1b7 [#23004] YCQL: Fix tserver crash due to NULL pointer dereference
 0ada80a [PLAT-14433] Use correct kubeconfig for edit provider validation
 eccbc10 [PLAT-14414] Enable Kubernetes provider validation by default
 199f679 [PLAT-14324]: Move all node agent based flags from BETA to INTERNAL in Provider Conf keys file
 86a865d [PLAT-14443] YBA Installer wait for ready time configurable.
 ac184a8 [#22882] YSQL: Fix deadlock in DDL atomicity
 a4218fb [Docs] Sort feature to tables (Where fulfills the criteria) (#22836)
 2f267ca [#22996] xCluster: Add SOURCE_UNREACHABLE and SYSTEM_ERROR enums

Skipped due to conflict:
dee7691 [#21534] docdb: Set owner correctly for cloned databases
34632ba [PLAT-14495] Set up the node_exporter for ynp
7c99ff9 [#22876][#22773] CDCSDK: Add new yb-admin command to remove user table from CDCSDK stream
4e9a81c [#22876][#22835][#22773] CDCSDK: Remove non-eligible tables for CDC from existing CDCSDK stream
f2e574e [#23013] xClusterDDLRepl: Allow table_ids for GetXClusterStreams

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: tfoucher, sanketh, jenkins-bot

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D36184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
None yet
Development

No branches or pull requests

2 participants