{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":105944401,"defaultBranch":"master","name":"yugabyte-db","ownerLogin":"yugabyte","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-10-05T21:56:00.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/17074854?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1719644416.0","currentOid":""},"activityList":{"items":[{"before":"cfbf51f588009a54009257835cfde24369a91d4e","after":"1b1b3a0ae6cc3722c4405adcf845e7244d4cf085","ref":"refs/heads/pg15","pushedAt":"2024-06-29T02:46:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jasonyb","name":null,"path":"/jasonyb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/93959687?s=80&v=4"},"commit":{"message":"[pg15] test: re-port regress yb_pg_foreign_data\n\nSummary:\nRe-port pg_regress test foreign_data to yb_pg_foreign_data. YB master\n830ba9964031fbcbff9e1fb07cf8a215cfd7c7fa adds some TRUNCATE queries that\nnever existed in upstream PG, so move these to a new yb_foreign_data,\nwith new corresponding schedule and Java test.\n\nTest Plan:\nOn Almalinux 8:\n\n #!/usr/bin/env bash\n set -eu\n ./yb_build.sh fastdebug --gcc11\n pg15_tests/test_lint.sh\n yes \"$(grep ForeignData pg15_tests/passing_tests.tsv)\" | head -100 | pg15_tests/run_tests.sh\n\nJenkins: rebase: pg15, test regex: ForeignData\n\nReviewers: fizaa, tfoucher\n\nReviewed By: tfoucher\n\nSubscribers: yql\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36257","shortMessageHtmlLink":"[pg15] test: re-port regress yb_pg_foreign_data"}},{"before":"6653c37240ab174dbf9ec41b585dec6446132e38","after":"444a0123b4dcefa4619761841522cfc1a6b90efb","ref":"refs/heads/2024.1","pushedAt":"2024-06-29T00:41:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"es1024","name":"Eric Sheng","path":"/es1024","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6742815?s=80&v=4"},"commit":{"message":"[2024.1][#23048] Revert \"[BACKPORT 2024.1][#21741] docdb: Filter intents by min running hybrid time during tablet bootstrap\"\n\nSummary:\nThis reverts commit 717fbc5caebbc146602a5ad738f5761fd1cdf48a, which caused CDC tests to\nstart failing, in order to unblock 2024.1 branch.\n\nTest Plan: Jenkins: urgent, rebase: 2024.1\n\nReviewers: rthallam\n\nReviewed By: rthallam\n\nSubscribers: ybase\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36255","shortMessageHtmlLink":"[2024.1][#23048] Revert \"[BACKPORT 2024.1][#21741] docdb: Filter inte…"}},{"before":"c0efeac1f858b8f60082d83a86be381e30600cf7","after":"6653c37240ab174dbf9ec41b585dec6446132e38","ref":"refs/heads/2024.1","pushedAt":"2024-06-29T00:08:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"yugabyte-ci","name":"YugaByte CI","path":"/yugabyte-ci","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17281578?s=80&v=4"},"commit":{"message":"Bumping version to 2024.1.2.0 on branch 2024.1","shortMessageHtmlLink":"Bumping version to 2024.1.2.0 on branch 2024.1"}},{"before":null,"after":"94ff887683730c803c953c60c3b900cb6721539d","ref":"refs/heads/2024.1.1","pushedAt":"2024-06-29T00:08:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yugabyte-ci","name":"YugaByte CI","path":"/yugabyte-ci","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17281578?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][PLAT-13096] Handling comma separated hosts in YBA-installer\n\nSummary:\nCurrently if multiple hostnames are set in yba-ctl.yml we do not handle it completely in all parts of the code. Specifically, our template files would generate incorrect configs and the status command would also appear strange. Also adds waiting for YBA during reconfigure, which is just a nice to have simple improvement.\nOriginal commit: d393043833c6fe8c4272095d807df261ada16099 / D33426\n\nTest Plan: yba-ctl install with no host set, single host set, and multiple hosts set\n\nReviewers: dshubin, sanketh\n\nReviewed By: dshubin\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36230","shortMessageHtmlLink":"[BACKPORT 2024.1][PLAT-13096] Handling comma separated hosts in YBA-i…"}},{"before":"63cceb3901c2f1150ff0177780ab662240b7ec05","after":"5c7715f06061bf48445c3e1e08412fe64b02856f","ref":"refs/heads/master","pushedAt":"2024-06-28T23:50:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"foucher","name":null,"path":"/foucher","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6496319?s=80&v=4"},"commit":{"message":"[#23057] YSQL: Fix missing newlines and pfree\n\nSummary:\n1. In our YugabyteDB-specific function yb_pclose_check, derived from exec.c's pclose_check, we use fprintf to stderr instead of log_error. fprintf doesn't append a newline to the end of its output. When we don't add a newline ourselves, the log output looks bad. Add newlines to yb_pclose_check in the missing places.\n2. yb_pclose_check gets reason from wait_result_to_str, which creates the reason string using pstrdup. But then yb_pclose_check frees the palloc'd memory using free. Change to pfree.\nJira: DB-11989\n\nTest Plan:\nJenkins: compile only\n\nAlso my workstation has a temporary problem right now that breaks initdb, so I manually examined that the output for initdb is fixed.\n\nOriginal:\n [m-1] child process exited with exit code 1initdb: removing data directory \"/tmp/tmp_pg_data_1768470008\"\n\nWith this fix:\n [m-1] child process exited with exit code 1\n [m-1] initdb: removing data directory \"/tmp/tmp_pg_data_158757254\"\n\nReviewers: jason, aagrawal\n\nReviewed By: jason\n\nSubscribers: yql\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36256","shortMessageHtmlLink":"[#23057] YSQL: Fix missing newlines and pfree"}},{"before":"4f1575ad2df551c30b191dbdf6971f613974dcbf","after":"cfbf51f588009a54009257835cfde24369a91d4e","ref":"refs/heads/pg15","pushedAt":"2024-06-28T23:43:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jasonyb","name":null,"path":"/jasonyb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/93959687?s=80&v=4"},"commit":{"message":"[pg15] test: remove pg15_tests/test_D29546.sh\n\nSummary:\nTestPgRegressYbFetchLimits passes as of\n1fbd01aa33f1c28725c72ce047ea2dd684439f0b. That commit missed removing\nthe shell test. Remove it now.\n\nTest Plan: Jenkins: skip\n\nReviewers: tfoucher\n\nReviewed By: tfoucher\n\nSubscribers: yql\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36260","shortMessageHtmlLink":"[pg15] test: remove pg15_tests/test_D29546.sh"}},{"before":"8becd35a530913bb0c8a7c25d07218e198dafc52","after":"f3b7a64732be9356ce1e9e3b25efafed39c4d86d","ref":"refs/heads/pg15-cherrypicks","pushedAt":"2024-06-28T23:27:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"myang2021","name":null,"path":"/myang2021","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79478033?s=80&v=4"},"commit":{"message":"[BACKPORT pg15-cherrypicks][#16408] YSQL: Split TestPgRegressIndex.testPgRegressIndex\n\nSummary:\nMerge YB master commit ec760627ce307485998ff79f15d1c54ec80b6d0c titled\n\n [#16408] YSQL: Split TestPgRegressIndex.testPgRegressIndex\n\nand committed 2024-06-28T16:41:49+00:00 into YB pg15.\n\n- yb_index_serial_schedule\n - YB pg15 96904194881e822ed4c29a0009ccab6b442d22d6 adds yb_index_including\n test. YB master ec760627ce307485998ff79f15d1c54ec80b6d0c splitted\n yb_index_serial_schedule into yb_index_serial_schedule and\n yb_index_serial2_schedule. Resolved the conflict by adding yb_index_including\n into yb_index_serial_schedule and kept yb_index_serials_schedule\n unchanged.\nJira: DB-5819\n\nTest Plan:\n./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressIndex#testPgRegressIndex'\n./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressIndex#testPgRegressIndex2'\n\nNote that both tests fail. The purpose is to examine that both completed\nwith 30 minutes. I made a pg15 release build without my change to run\n\n./yb_build.sh release --java-test 'org.yb.pgsql.TestPgRegressIndex#testPgRegressIndex'\n\nIt also fails and those failed tests have identical test output so this diff\ndoes not alter the test outputs.\n\nReviewers: jason, tfoucher\n\nReviewed By: jason\n\nSubscribers: yql\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36252","shortMessageHtmlLink":"[BACKPORT pg15-cherrypicks][#16408] YSQL: Split TestPgRegressIndex.te…"}},{"before":"d0e93c9b984162033f1ca08994d89385a1fbb6f5","after":"63cceb3901c2f1150ff0177780ab662240b7ec05","ref":"refs/heads/master","pushedAt":"2024-06-28T22:54:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"andrei-mart","name":"Andrei Martsinchyk","path":"/andrei-mart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1223507?s=80&v=4"},"commit":{"message":"[#22837] YSQL: Fix fast path insert into tables with identity columns\n\nSummary:\nThere are differences in implementation of autoincrement columns defined\nas \"serial\" and \"generated as identity\". Serial columns have defaults,\ndefined as nextval('#22837] YSQL: Fix fast path insert into tables with identity columns"}},{"before":"5add5458370f4f55e5965563040b07db57103ebc","after":"8becd35a530913bb0c8a7c25d07218e198dafc52","ref":"refs/heads/pg15-cherrypicks","pushedAt":"2024-06-28T22:52:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"SrivastavaAnubhav","name":"Anubhav Srivastava","path":"/SrivastavaAnubhav","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17299377?s=80&v=4"},"commit":{"message":"[BACKPORT pg15-cherrypicks][#21534] docdb: Set owner correctly for cloned databases\n\nSummary:\nThis is a manual backport of dee7691cd265d41352af56c7e41c8d3cf1f30df1 which failed to automatically merge.\n\nOriginal commit: dee7691cd265d41352af56c7e41c8d3cf1f30df1 / D35799\n\nPrior to this diff, the owner of the cloned database was the same as the owner of the source database. This diff adds a modification to the ysql_dump output to rewrite the ALTER ____ foo OWNER TO yugabyte to point to the correct user (the user running the CREATE DATABASE WITH TEMPLATE command by default or the OWNER (if set).\n\nUpgrade/Rollback safety:\nAltered protobuf is not used in production at the moment.\n\nThe following merge conflicts were resolved:\n- `bootstrap.c`\n - This commit removes the `const char *src_dbname` and `int64 clone_time` parameters from `YBCCreateDatabase` and instead passes them in a struct `YbCloneInfo`.\n - An adjacent change renamed `FirstBootstrapObjectId` to `YbFirstBootstrapObjectId` in this file, while my master commit removes the `src_dbname` and `clone_time` arguments.\n- `dbcommands.c`: add clone-specific code to both branches of `YBCCreateDatabase`\n - This postgres commit introduced an if-else branch in the `createdb` where we used to call `YBCCreateDatabase`. This caused an indentation change which caused a merge conflict, since the code from YB's master branch modified the arguments to `YBCCreateDatabase`. Additionally, the pg15 commit 84fe79f8ba08095ef0fc7f53fa627b1f838f1012 added a `YBCCreateDatabase` call into the if case. The resolution is to make the same changes to the arguments of `YBCCreateDatabase` in both the if and the else branches. The code to check whether the create is a clone is common and can be moved before the if-else.\nJira: DB-10420\n\nTest Plan: `./yb_build.sh release --cxx-test integration-tests_minicluster-snapshot-test --gtest_filter PgCloneTest.UserIsSet`\n\nReviewers: jason\n\nReviewed By: jason\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36218","shortMessageHtmlLink":"[BACKPORT pg15-cherrypicks][#21534] docdb: Set owner correctly for cl…"}},{"before":"8524d95bdc07789f835034de43a98883c9de1843","after":"28739e54d63993680803a11ae36bc6fa82a9e3f8","ref":"refs/heads/2.20","pushedAt":"2024-06-28T22:41:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"shubin-yb","name":"Daniel Shubin","path":"/shubin-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117757925?s=80&v=4"},"commit":{"message":"[BACKPORT 2.20][PLAT-14511] Improved yba installer migrations to allow some versions to not exist\n\nSummary:\nOriginal commit: e5399d967ec7fe28a99e5cad21e4ee86b0ddc5fe / D36217\nThis is very useful when backporting some migrations but not others. It allows\nyba installer to apply schemas even when a version is \"missing\", but allow a\nfuture upgrade to apply that missing schema\n\nTest Plan:\nseveral unit tests to validate functionality\ntested an install and an upgrade to validate the migrations\nwork as expected\n\nReviewers: muthu, sanketh\n\nReviewed By: muthu\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36251","shortMessageHtmlLink":"[BACKPORT 2.20][PLAT-14511] Improved yba installer migrations to allo…"}},{"before":"94ff887683730c803c953c60c3b900cb6721539d","after":"c0efeac1f858b8f60082d83a86be381e30600cf7","ref":"refs/heads/2024.1","pushedAt":"2024-06-28T22:40:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"shubin-yb","name":"Daniel Shubin","path":"/shubin-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117757925?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][PLAT-14511] Improved yba installer migrations to allow some versions to not exist\n\nSummary:\nOriginal commit: e5399d967ec7fe28a99e5cad21e4ee86b0ddc5fe / D36217\nThis is very useful when backporting some migrations but not others. It allows\nyba installer to apply schemas even when a version is \"missing\", but allow a\nfuture upgrade to apply that missing schema\n\nTest Plan:\nseveral unit tests to validate functionality\ntested an install and an upgrade to validate the migrations\nwork as expected\n\nReviewers: muthu, sanketh\n\nReviewed By: muthu\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36250","shortMessageHtmlLink":"[BACKPORT 2024.1][PLAT-14511] Improved yba installer migrations to al…"}},{"before":"da6cbd50cd22a71b733ef64da8586505b1e03913","after":"d0e93c9b984162033f1ca08994d89385a1fbb6f5","ref":"refs/heads/master","pushedAt":"2024-06-28T22:22:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"amannijhawan","name":"Aman Nijhawan","path":"/amannijhawan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1563216?s=80&v=4"},"commit":{"message":"[PLAT-14104] Network configuration module for YNP\n\nSummary: [PLAT-14104] Network configuration module for YNP\n\nTest Plan: Tested by dumping the precheck, run scripts\n\nReviewers: svarshney\n\nReviewed By: svarshney\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36034","shortMessageHtmlLink":"[PLAT-14104] Network configuration module for YNP"}},{"before":"f20048b1c9abb0d91e247b4792a2681e88594f1b","after":"da6cbd50cd22a71b733ef64da8586505b1e03913","ref":"refs/heads/master","pushedAt":"2024-06-28T22:07:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ddhodge","name":"Dwight Hodge","path":"/ddhodge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79169168?s=80&v=4"},"commit":{"message":"[DOC-396] Set up SSO using Jumpcloud (#22861)\n\n* added jumpcloud SSO\r\n\r\n* modified as per review\r\n\r\n* Apply suggestions from code review\r\n\r\nCo-authored-by: Dwight Hodge <79169168+ddhodge@users.noreply.github.com>\r\n\r\n* changes from review\r\n\r\n* review comments\r\n\r\n* format and minor edits\r\n\r\n---------\r\n\r\nCo-authored-by: Dwight Hodge <79169168+ddhodge@users.noreply.github.com>\r\nCo-authored-by: Dwight Hodge ","shortMessageHtmlLink":"[DOC-396] Set up SSO using Jumpcloud (#22861)"}},{"before":"e7ad4f844b86b49d555562192d6c7202ebc5f04c","after":"5add5458370f4f55e5965563040b07db57103ebc","ref":"refs/heads/pg15-cherrypicks","pushedAt":"2024-06-28T21:18:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jasonyb","name":null,"path":"/jasonyb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/93959687?s=80&v=4"},"commit":{"message":"[BACKPORT pg15-cherrypicks] all: Bulk port from master - 44\n\nSummary:\n 9c637e2 [PLAT-14429]: Modify Troubleshooting Platform registration workflow in YBA\n 0a1406d [PLAT-14098]: Updating yb.runtime_conf_ui.tag_filter with appropriate tags value does not display the flags accordingly\n 70a87f9 [PLAT-13605][PLAT-13609]: Edit Volume controls and storage type in FULL_MOVE but not in case of UPDATE\n 26fbfe0 [PLAT-14515][UI] Clicking preview doesn't show the correct info and clears up the data provided while setting up the ysql_ident or ysql_hba multiline flags.- [PLAT-14514] [PLAT-14513]\n a07946b [#18233] Initial commit for yugabyted unit test framework.\n b2e8ee7 [#22842] docdb: Improve usability of stack trace tracking endpoints\n 508f26e [docs] Added RN 2.20.2.3-b2 (#23042)\n 214d44a [#22935] YSQL: Use db oid in the tserver's sequence cache entry key\n c47b2d9 [#22802] YSQL: Avoid renaming DocDb tables during legacy rewrite\n Excluded: 7c8343d [#22874] YSQL: Fix cascaded drops on columns\n 58c8d4e [#23046] xCluster: Remove ns_replication from the code\n a70681d [#22816] YSQL: Bug fixes for replication connections in ysql connection manager\n b239e07 Doc upgrade versions (#22988)\n Excluded: ec76062 [#16408] YSQL: Split TestPgRegressIndex.testPgRegressIndex\n\nTest Plan: Jenkins: rebase: pg15-cherrypicks\n\nReviewers: jason, tfoucher\n\nSubscribers: yql\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36247","shortMessageHtmlLink":"[BACKPORT pg15-cherrypicks] all: Bulk port from master - 44"}},{"before":"841fbdb87ba332795ff5f74f15a1cd4ddada184f","after":"f20048b1c9abb0d91e247b4792a2681e88594f1b","ref":"refs/heads/master","pushedAt":"2024-06-28T20:57:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"basavaraj29","name":"Basava Kolagani","path":"/basavaraj29","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17742021?s=80&v=4"},"commit":{"message":"[#22840] DocDB: Fix DFATAL in WaitQueue::Impl::HandleWaiterStatusRpcResponse\n\nSummary:\nhttps://github.com/yugabyte/yugabyte-db/commit/2896530b3a9eb209ecb79d4665c0ffb4b10bd52a refactored the way we maintain waiters at the wait-queue, changing `waiter_status_` to track `WaitingTxn` which internally stores all waiting rpc requests, `WaiterData`(s), corresponding to the transaction at the tablet.\n\nEarlier, we used to remove the waiter from `waiter_status_` when executing its callback, but now we only erase the waiter either on processing the txn status response or when we see that all rpc requests of this waiter have been resolved.\n\nthe following could happen\n```\n1. Poll sees a waiting request for the `WaitingTxn`, and launches a status request\n2. The blocker for the rpc request resolves, and the waiting rpc request's callback is executed\n3. The waiter txn (which is no longer blocked) commits.\n4. The txn coordinator processes the status response and returns COMMITTED\n5. HandleWaiterStatusRpcResponse processes the response and DFATALs seeing COMMITTED status\n```\n\nWith the current state of the code, it should be totally okay to see `COMMITTED` or other resolved txn statuses for a `WaitingTxn` which is no longer blocked. Hence DFATAL only if we see resolved txn statuses when `WaitingTxn` has active waiting requests.\n\nNote: This isn't an issue in release mode anyways since the next iteration of `Poll` would purge the `WaitingTxn`.\nJira: DB-11737\n\nTest Plan:\n./yb_build.sh fastdebug --cxx-test pgwrapper_pg_wait_on_conflict-test --gtest_filter PgWaitQueueContentionStressTest.TestResumeWaitersOnScheduler -n 50 --tp 1\n./yb_build.sh fastdebug --cxx-test pgwrapper_pg_wait_on_conflict-test --gtest_filter PgWaitQueuesTest.DeadlockResolvesYoungestTxn -n 50 --tp 1\n\nReviewers: pjain, rthallam, patnaik.balivada\n\nReviewed By: patnaik.balivada\n\nSubscribers: ybase\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36143","shortMessageHtmlLink":"[#22840] DocDB: Fix DFATAL in WaitQueue::Impl::HandleWaiterStatusRpcR…"}},{"before":"2c0c402401c82b1b9c4634834240f776422abdc2","after":"e7ad4f844b86b49d555562192d6c7202ebc5f04c","ref":"refs/heads/pg15-cherrypicks","pushedAt":"2024-06-28T20:01:18.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"jasonyb","name":null,"path":"/jasonyb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/93959687?s=80&v=4"},"commit":{"message":"[#22876][#22835][#22773] CDCSDK: Remove non-eligible tables for CDC from existing CDCSDK stream\n\nSummary:\nSome non-eligible tables like indexes etc. created after creation of a CDC stream were getting added to the CDC stream due to [[ https://phorge.dev.yugabyte.com/D35856 | this missing logic in addition of dynamic tables codepath ]]. We do not hold retention barriers on tablets of such tables until and unless they split, in which case, we start holding retention barriers on the children tablets. This leads to heavy resource usage over time and since the CDC stream never polls on tables of such tables, retention barriers are not lifted until the active time of these tablets exceed `cdc_intent_retention_ms`.\n\nTherefore, to prevent resource consumption from such tables, we want to achieve the following:\n1. Remove these non-eligible tables from the stream metadata so that any further tablet splitting on these tables do not lead to addition of children tablets in cdc state table.\n2. Release retention barriers on the existing tablets that are part of the cdc state table and finally remove these state table entries.\n\nWe have followed the same pattern of achieving the above tasks via a background thread, exactly similar to addition of dynamic table in CDC streams.\n\n**Working:**\n\n - //FindAllNonUserTablesInCDCSDKStream// - On a master restart/leadership change, while loading CDCSDK streams into memory, we will compute the set difference between tables present in stream metadata and tables in the namespace that are eligible for a CDC stream. This set difference will give us the set of non-eligible tables that were not supposed to get added to the CDC stream, but got added because of the above mentioned bug. These non-eligible tables will be added to `namespace_to_cdcsdk_non_user_table_map_` which is further processed in catalog manager background thread by //FindCDCSDKStreamsForNonUserTables//.\n\n The bg thread of catalog manager (CatalogManagerBgTasks), with the following methods handles the actual table removal:\n\n - //FindCDCSDKStreamsForNonUserTables//: This method is run in every subsequent iteration of the bg thread of catalog manager. It scans the cdc_stream_map_ and finds all streams in ACTIVE/DELETING METADATA state which have the non-eligible table entry in stream metadata, and collects the details to be further processed by //RemoveNonUserTablesForCDCSDKStreams//.\n - //RemoveNonUserTablesForCDCSDKStreams//: This method is run after FindCDCSDKStreamsForNonUserTables and does the following for each stream that contains the non-eligible table entry:\n 1. Update the checkpoint of cdc state entries related to non-eligible table to OpId max. Incase of colocated tables, entries with a colocated_table_id will be deleted.\n 2. Removes the table from stream metadata and cdcsdk_tables_to_stream_map_.\n Once the table is removed from all relevant CDC streams, then we remove the table entry from `namespace_to_cdcsdk_non_user_table_map_`.\n\nNote:\n1. To enable this cleanup of non-eligible tables, user has to set the master flag `enable_cleanup_of_non_eligible_tables_from_cdcsdk_stream`.\n2. In single iteration of the bg thread, we only process two non-eligible tables across all namespaces. This processing limit is configurable and we are reusing the existing flag `cdcsdk_table_processing_limit_per_run`.\n\nAdditionally, in the tablet split codepath, before adding cdc state entries for children tables, we will now check if the table is a non-eligible table for CDC stream or not. This also helps in preventing a race condition when a tablet of a non-eligible is split and concurrently, there was a master restart/leadership changes and we are trying to remove the table from stream metadata.\nJira: DB-11778, DB-11733, DB-11676\n\nTest Plan:\nJenkins: urgent\n./yb_build.sh --cxx-test integration-tests_cdcsdk_ysql-test --gtest_filter CDCSDKYsqlTest.TestNonEligibleTableRemovalFromNonConsistentSnapshotCDCStream\n./yb_build.sh --cxx-test integration-tests_cdcsdk_ysql-test --gtest_filter CDCSDKYsqlTest.TestNonEligibleTableRemovalFromConsistentSnapshotCDCStream\n\n./yb_build.sh --cxx-test integration-tests_cdcsdk_ysql-test --gtest_filter CDCSDKYsqlTest.TestChildTabletsOfNonEligibleTableDoNotGetAddedToNonConsistentSnapshotStream\n./yb_build.sh --cxx-test integration-tests_cdcsdk_ysql-test --gtest_filter CDCSDKYsqlTest.TestChildTabletsOfNonEligibleTableDoNotGetAddedToConsistentSnapshotStream\n\nReviewers: asrinivasan, stiwary, skumar\n\nReviewed By: stiwary\n\nSubscribers: ycdcxcluster\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36031","shortMessageHtmlLink":"[#22876][#22835][#22773] CDCSDK: Remove non-eligible tables for CDC f…"}},{"before":"4b1dd4abd04fe052428bdcbb15f1bf8f4f9a44eb","after":"2c0c402401c82b1b9c4634834240f776422abdc2","ref":"refs/heads/pg15-cherrypicks","pushedAt":"2024-06-28T19:59:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jasonyb","name":null,"path":"/jasonyb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/93959687?s=80&v=4"},"commit":{"message":"[BACKPORT pg15-cherrypicks][PLAT-14495] Set up the node_exporter for ynp\n\nSummary: Configure node_exporter module for ynp\n\nOriginal commit: 34632ba / D36115\n\nmanually cherry-picked this.","shortMessageHtmlLink":"[BACKPORT pg15-cherrypicks][PLAT-14495] Set up the node_exporter for ynp"}},{"before":"0db5d1621a2fa8808fad7f86efb2ae5dfb0e6deb","after":"841fbdb87ba332795ff5f74f15a1cd4ddada184f","ref":"refs/heads/master","pushedAt":"2024-06-28T19:31:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"yusong-yan","name":"yusongyan","path":"/yusong-yan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46516278?s=80&v=4"},"commit":{"message":"[#21829] docdb: Fix scan that does not honor timeouts in certain scenarios, to not run into runaway scan scenarios.\n\nSummary:\n**Issue**\nOur code was encountering reads that took longer than 180 seconds even though a timeout of 60 seconds was set. Current read deadline is only checked when processing subdocs of a row(Introduced in D5808). However, in certain cases, before we even process the subdocs, the code might skip the row (code link), meaning read deadline will not be checked.\n```\nResult DocRowwiseIterator::FetchNextImpl(TableRow table_row) {\n ...\n if (!is_static_column &&\n !VERIFY_RESULT(scan_choices_->InterestedInRow(&row_key_, db_iter_.get()))) {\n continue;\n }\n ...\n```\nIf this frequently occurs during a read operation, the read will continue indefinitely even after the read deadline has passed. This issue was not handled by D5808.\n\n**Queries That Can Lead to This Issue**\nThis issue can occur when reading through a non-prefix of an index key. For an index with a key structure of (k1, k2, k3, k4, …), a query that sets a non-prefix of these keys could cause this problem:\nSELECT * FROM table WHERE k1 = x AND k3 = y\nSELECT * FROM table WHERE k1 = x AND k4 = y\nHere is an example:\n```\nCREATE TABLE test_table (custid text, acctid int, roletitle text, PRIMARY KEY (custid, acctid, roletitle) ) WITH transactions = { 'enabled' : true };\n\nINSERT INTO test_table (custid, acctid, roletitle) VALUES ('cust123', 1, 'Manager');\nINSERT INTO test_table (custid, acctid, roletitle) VALUES ('cust123', 2, 'Developer');\nINSERT INTO test_table (custid, acctid, roletitle) VALUES ('cust123', 3, 'Developer');\nINSERT INTO test_table (custid, acctid, roletitle) VALUES ('cust123', 4, 'Developer');\n\nselect acctid from test_table where custid = 'cust123' AND roletitle = 'Manager';\n```\nAfter reading the Manager row, we then walk through the next three rows without checking deadline.\n\n**Fix:**\nAdded deadline check at the beginning of processing each row to prevent the above issue from happening. And created a unit test to validate it.\nJira: DB-10731\n\nTest Plan: Jenkins: test regex: .*CqlTest.*\n\nReviewers: hsunder, rthallam\n\nReviewed By: hsunder, rthallam\n\nSubscribers: yugaware, ybase, rthallam, slingam\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35108","shortMessageHtmlLink":"[#21829] docdb: Fix scan that does not honor timeouts in certain scen…"}},{"before":"e3caa8d41fc18a909d719aec93f880fed139e2aa","after":"94ff887683730c803c953c60c3b900cb6721539d","ref":"refs/heads/2024.1","pushedAt":"2024-06-28T18:59:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chidmuthu","name":"Muthu Chidambaram","path":"/chidmuthu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86024920?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][PLAT-13096] Handling comma separated hosts in YBA-installer\n\nSummary:\nCurrently if multiple hostnames are set in yba-ctl.yml we do not handle it completely in all parts of the code. Specifically, our template files would generate incorrect configs and the status command would also appear strange. Also adds waiting for YBA during reconfigure, which is just a nice to have simple improvement.\nOriginal commit: d393043833c6fe8c4272095d807df261ada16099 / D33426\n\nTest Plan: yba-ctl install with no host set, single host set, and multiple hosts set\n\nReviewers: dshubin, sanketh\n\nReviewed By: dshubin\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36230","shortMessageHtmlLink":"[BACKPORT 2024.1][PLAT-13096] Handling comma separated hosts in YBA-i…"}},{"before":"e5399d967ec7fe28a99e5cad21e4ee86b0ddc5fe","after":"0db5d1621a2fa8808fad7f86efb2ae5dfb0e6deb","ref":"refs/heads/master","pushedAt":"2024-06-28T18:35:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hari90","name":"Hari Krishna Sunder","path":"/hari90","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12418230?s=80&v=4"},"commit":{"message":"[14279] YSQL: Add basic flag validation for ysql_pg_conf_csv, ysql_hba_conf_csv and ysql_ident_conf_csv\n\nSummary:\nThis diff adds basic flag validation for ysql_pg_conf_csv, ysql_hba_conf_csv and ysql_ident_conf_csv. The validation check if the csv passes the `ReadCSVValues` function and make sure the individual values do not contain any newline characters.\nPostgres validates this the pg_conf values using `ParseConfigFp` function in `guc-file.c` using a lexer, which is very very complicated to correctly mimic using a regex. So, we currently cannot fully guarantee the validity of the value.\n\nTest Plan: PgWrapperFlagsTest.ValidateYsqlPgConfCsv\n\nReviewers: jason\n\nReviewed By: jason\n\nSubscribers: ybase, yql\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36194","shortMessageHtmlLink":"[14279] YSQL: Add basic flag validation for ysql_pg_conf_csv, ysql_hb…"}},{"before":"9b83b808c6a9c5597ce9039c12f553ae96782eea","after":"e5399d967ec7fe28a99e5cad21e4ee86b0ddc5fe","ref":"refs/heads/master","pushedAt":"2024-06-28T18:34:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"shubin-yb","name":"Daniel Shubin","path":"/shubin-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117757925?s=80&v=4"},"commit":{"message":"[PLAT-14511] Improved yba installer migrations to allow some versions to not exist\n\nSummary:\nThis is very useful when backporting some migrations but not others. It allows\nyba installer to apply schemas even when a version is \"missing\", but allow a\nfuture upgrade to apply that missing schema\n\nTest Plan:\nseveral unit tests to validate functionality\ntested an install and an upgrade to validate the migrations\nwork as expected\n\nReviewers: muthu, sanketh\n\nReviewed By: muthu\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36217","shortMessageHtmlLink":"[PLAT-14511] Improved yba installer migrations to allow some versions…"}},{"before":"26cd461737bc82eed9aba380a8d41f2e67d751c3","after":"9b83b808c6a9c5597ce9039c12f553ae96782eea","ref":"refs/heads/master","pushedAt":"2024-06-28T18:27:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"SrivastavaAnubhav","name":"Anubhav Srivastava","path":"/SrivastavaAnubhav","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17299377?s=80&v=4"},"commit":{"message":"[#23036] docdb: Switch CloneStateInfo object from scoped_refptr to std::shared_ptr\n\nSummary:\nstd::shared_ptr is more standard, and lets us use std::weak_ptr in the future.\n\nFixes #23036\nJira: DB-11968\n\nTest Plan: existing tests\n\nReviewers: zdrudi\n\nReviewed By: zdrudi\n\nSubscribers: ybase\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36200","shortMessageHtmlLink":"[#23036] docdb: Switch CloneStateInfo object from scoped_refptr to st…"}},{"before":"d54e0df678bf38f6afbcf19e4b8c3cbaa05b000e","after":"e3caa8d41fc18a909d719aec93f880fed139e2aa","ref":"refs/heads/2024.1","pushedAt":"2024-06-28T18:12:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"myang2021","name":null,"path":"/myang2021","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79478033?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][#22882] YSQL: Fix deadlock in DDL atomicity\n\nSummary:\nIn working on diff https://phorge.dev.yugabyte.com/D32682, I found one deadlock\nthat caused a test to be flaky. The dead lock involved 3 threads.\n\nThread A is executing yb::RWCLock::UpgradeToCommitLock:\n```\nvoid RWCLock::UpgradeToCommitLock() {\n lock_.lock();\n DCHECK(write_locked_);\n bool first_wait = true;\n while (reader_count_ > 0) {\n if (!no_readers_.TimedWait(first_wait ? kFirstWait : kSecondWait)) {\n std::ostringstream ss;\n ss << \"Too long commit lock wait, num readers: \" << reader_count_\n << \", current thread stack: \" << GetStackTrace();\n```\n\nThread A blocks because `reader_count_ > 0`, while it holds the write lock:\n\n```\n DCHECK(write_locked_);\n```\n\nThread A is executing the work flow of an ALTER TABLE statement with a call chain\n\n```\nyb::RWCLock::UpgradeToCommitLock\nyb::CowObject::CommitMutation\nyb::CowWriteLock::Commit\nyb::master::CatalogManager::ClearYsqlDdlTxnState\nyb::master::CatalogManager::HandleSuccessfulYsqlDdlTxn\nyb::master::CatalogManager::YsqlDdlTxnCompleteCallbackInternal\n\n```\nFrom test log I see the thread (Thread B) that caused `reader_count_ > 0` is\ncalling `GetTableSchemaInternal`:\n\nThread B:\n\n```\nStatus CatalogManager::GetTableSchemaInternal(const GetTableSchemaRequestPB* req,\n GetTableSchemaResponsePB* resp,\n bool get_fully_applied_indexes) {\n VLOG(1) << \"Servicing GetTableSchema request for \" << req->ShortDebugString();\n\n // Lookup the table and verify if it exists.\n TRACE(\"Looking up table\");\n scoped_refptr table = VERIFY_RESULT(FindTable(req->table()));\n\n TRACE(\"Locking table\");\n auto l = table->LockForRead();\n\n......\n auto nsinfo = FindNamespaceById(table->namespace_id());\n```\n\nThread B causes `reader_count_ > 0` via `table->LockForRead()` and it is blocked\ninside `FindNamespaceById` in order to get a shared lock on `mutex_` of `CatalogManager`:\n\n```\nResult> CatalogManager::FindNamespaceById(\n const NamespaceId& id) const {\n SharedLock lock(mutex_);\n return FindNamespaceByIdUnlocked(id);\n}\n```\n\nThe `mutex_` is held exclusively by Thread C from `CatalogManager::CreateTable`:\n```\n {\n LockGuard lock(mutex_);\n auto ns_lock = ns->LockForRead();\n......\n if (IsIndex(req)) {\n TRACE(\"Locking indexed table\");\n indexed_table_write_lock = indexed_table->LockForWrite();\n }\n......\n }\n```\n\nNote Thread C exclusively holds `mutex_` via `LockGuard`, and it is blocked on\n`LockForWrite`, which calls `RWCLock::WriteLock` and cannot proceed because\n`write_locked_` (owned by Thread A).\n\n```\nvoid RWCLock::WriteLock() {\n ThreadRestrictions::AssertWaitAllowed();\n\n MutexLock l(lock_);\n // Wait for any other mutations to finish.\n bool first_wait = true;\n while (write_locked_) {\n if (!no_mutators_.TimedWait(first_wait ? kFirstWait : kSecondWait)) {\n```\n\nIn summary, we have a deadlock cycle:\nThread A (holds write_locked_) waits for Thread B to release reader_count_\nThread B (holds reader_count_) waits for Thread C to release mutex_\nThread C (holds mutex_) waits for Thread A to release write_locked_\n\nTo break the dead lock cycle, I made changes in Thread C, so that it will release\nthe exclusive lock on `mutex_` before calling `LockForWrite`. In addition,\nit does not need to re-acquire `mutex_` after `LockForWrite` because the rest\ncode in the relevant scope does not need to be protected by having an exclusive\nlock on `mutex_`.\nJira: DB-11784\n\nOriginal commit: ac184a8861 / D35843\n\nTest Plan: Tested in the context of https://phorge.dev.yugabyte.com/D32682.\n\nReviewers: hsunder, asrivastava, zdrudi\n\nReviewed By: asrivastava\n\nSubscribers: yql, ybase, zdrudi\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36229","shortMessageHtmlLink":"[BACKPORT 2024.1][#22882] YSQL: Fix deadlock in DDL atomicity"}},{"before":"294254749e22fc301d1027a2eb7f89368b4b75d3","after":"4b1dd4abd04fe052428bdcbb15f1bf8f4f9a44eb","ref":"refs/heads/pg15-cherrypicks","pushedAt":"2024-06-28T18:10:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hulien22","name":"Julien He","path":"/hulien22","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32774836?s=80&v=4"},"commit":{"message":"[BACKPORT pg15-cherrypicks][#23013] xClusterDDLRepl: Allow table_ids for GetXClusterStreams\n\nSummary:\nOriginal commit: f2e574e / D36136\nAs part of using table_ids for xCluster DDL Replication to match tables together, we need to be able\nto request streams by producer table ids as well. This will be used in add_table_to_target_task in a\nfollow-up diff (D35874).\n\n**Upgrade/Rollback safety:**\nOnly adding in new proto fields\nJira: DB-11942\n\nTest Plan:\n```\nybd --cxx-test xcluster_outbound_replication_group-itest --gtest_filter \"XClusterOutboundReplicationGroupTest.TestGetStreamByTableId\"\n```\n\nReviewers: hsunder, xCluster, jason\n\nReviewed By: jason\n\nSubscribers: ybase\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36231","shortMessageHtmlLink":"[BACKPORT pg15-cherrypicks][#23013] xClusterDDLRepl: Allow table_ids …"}},{"before":"25d427a974b47086a627828af5f975f9cb2c27fb","after":"26cd461737bc82eed9aba380a8d41f2e67d751c3","ref":"refs/heads/master","pushedAt":"2024-06-28T17:35:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"shubin-yb","name":"Daniel Shubin","path":"/shubin-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117757925?s=80&v=4"},"commit":{"message":"[PLAT-14165] Health check to report on time drift.\n\nSummary:\nAdded a new health check that uses chrony to report warnings and errors\ndepending on the amount of drift (250 ms for warning and 400 for error\nby default).\n\nIf chrony is not installed, the health check skips and does not report\nanything\n\nTest Plan:\n1. chrony installed with 0 offset (check passed)\n2. chrony installed with large offset (check reported error)\n3. chrony not installed (check skipped)\n4. chrony stopped (check reported error)\n5. hard coded drift_ms for error and warnings (reported error/warning as expected)\n\nReviewers: vbansal, yshchetinin, svarshney, amalyshev\n\nReviewed By: amalyshev\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36145","shortMessageHtmlLink":"[PLAT-14165] Health check to report on time drift."}},{"before":"ec760627ce307485998ff79f15d1c54ec80b6d0c","after":"25d427a974b47086a627828af5f975f9cb2c27fb","ref":"refs/heads/master","pushedAt":"2024-06-28T17:32:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"kv83821-yb","name":"Kumar Vivek","path":"/kv83821-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/42805130?s=80&v=4"},"commit":{"message":"[PLAT-13975] Support for non-restart gflags upgrade in Kubernetes universes\n\nSummary:\nThis PR adds support for non-restart based gflags upgrade in Kubernetes universes. Earlier we only supported rolling/non-rolling restarts. The PR now provides a third option for runtime settable gflags to be set without restarting pods. This PR is accompanied by a DB helm charts feature support for non-restart gflags: https://phorge.dev.yugabyte.com/D35040.\n\nNon-restart gflags upgrade flow\n- We will first fetch the gflags checksum from the statefulsets using a `kubectl get` call and use that checksum for subsequent helm upgrade.\n- We will use the SetFlagInMemory flow to update the gflags value in memory.\n\nEdit Universe\n- The above change also enables us to modify two non-restart gflags: `master_addresses` for Master process and `tserver_master_addrs` for Tserver process.\n- We will first fetch the checksum values and use them to do the subsequent Helm upgrade tasks if required. If restarting the pods is still required( for cases such as instance type change ) we will not provide the previous checksum.\n- We will use the SetFlagInMemory flow to update the gflags value in memory.\n- For resize disk flow, we will first fetch the checksum and then save it in the task params. This is done to ensure a retry can still access the older checksum, because the task may end up failing at STS delete step, we would need the older checksum in that case.\n\nTest Plan:\n- Verified non-restart gflags checksum works as expected with runtime modifiable gflags.\n- Verified Edit universe with AZ remove and add scenarios, which modifies the master addresses.\n\nReviewers: anijhawan, #yba-api-review, sanketh, sneelakantan, bgandhi\n\nReviewed By: anijhawan, #yba-api-review\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35519","shortMessageHtmlLink":"[PLAT-13975] Support for non-restart gflags upgrade in Kubernetes uni…"}},{"before":"b239e07cd040b757f3dba9472ee416526ea285b4","after":"ec760627ce307485998ff79f15d1c54ec80b6d0c","ref":"refs/heads/master","pushedAt":"2024-06-28T16:41:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"myang2021","name":null,"path":"/myang2021","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79478033?s=80&v=4"},"commit":{"message":"[#16408] YSQL: Split TestPgRegressIndex.testPgRegressIndex\n\nSummary:\nThe unit test org.yb.pgsql.TestPgRegressIndex.testPgRegressIndex oftens times\nout with an error like:\n```\norg.junit.runners.model.TestTimedOutException: test timed out after 1800 seconds\n```\n\nI splitted the schedule `yb_index_serial_schedule` into two so that each has a\nbetter chance not to time out. They each take about the same run time.\nJira: DB-5819\n\nTest Plan:\n./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressIndex#testPgRegressIndex'\n./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressIndex#testPgRegressIndex2'\n\nOn my dev vm debug build, testPgRegressIndex runs about 18:30 minutes,\ntestPgRegressIndex2 runs about 19 minutes.\n\nReviewers: fizaa\n\nReviewed By: fizaa\n\nSubscribers: yql\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36224","shortMessageHtmlLink":"[#16408] YSQL: Split TestPgRegressIndex.testPgRegressIndex"}},{"before":"9b3124d65c8a1a4da0870869e2fb2f358d9375da","after":"4f1575ad2df551c30b191dbdf6971f613974dcbf","ref":"refs/heads/pg15","pushedAt":"2024-06-28T16:39:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fizaaluthra","name":null,"path":"/fizaaluthra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20885072?s=80&v=4"},"commit":{"message":"[pg15] fix: get TestPgSortNumeric to pass\n\nSummary:\nTestPgSortNumeric checks for invalid decimal values like `Infinity`. However, upstream\nPG commit a57d312a7706321d850faa048a562a0c0c01b835 adds support for `Infinity`,\nso it no longer leads to PG layer errors, but causes assertion failures in DocDB code-paths.\nFor now, disable support for `Infinity` for numeric types.\n\nTest Plan:\n```\nfor _ in {1..50}; do grep -E TestPgSortNumeric pg15_tests/passing_tests.tsv; done | pg15_tests/run_tests.sh\n```\n\nReviewers: jason\n\nReviewed By: jason\n\nSubscribers: yql\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36178","shortMessageHtmlLink":"[pg15] fix: get TestPgSortNumeric to pass"}},{"before":"fc34a89fd482cb07550593e8653ff69c94cddf91","after":"8524d95bdc07789f835034de43a98883c9de1843","ref":"refs/heads/2.20","pushedAt":"2024-06-28T16:37:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"shahrooz1997","name":"Hamidreza Zare","path":"/shahrooz1997","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/23063104?s=80&v=4"},"commit":{"message":"[BACKPORT 2.20][PLAT-14325] Reduce wait time for PITR config creation from 15 seconds to 1 second\n\nSummary:\nThis diff makes changes to reduce the PITR time by reducing the wait time before the check whether the PITR setup is done and rechecking if it is not.\n\nOriginal commit: 59b03acdfe5da826223af9c2fcf7b05bd0ed2608 / D36035\n\nTest Plan:\n- Made sure PITR is set up in about 2 seconds.\n- Made sure when the delay is 100ms, the retry logic happens a couple of times before the create PITR task completes.\n\nReviewers: #yba-api-review!, sanketh, cwang, vbansal, vpatibandla\n\nReviewed By: cwang\n\nSubscribers: yugaware, sneelakantan\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36225","shortMessageHtmlLink":"[BACKPORT 2.20][PLAT-14325] Reduce wait time for PITR config creation…"}},{"before":"144dcd4d529c80245382bfd8a54eba3bbe0e418c","after":"d54e0df678bf38f6afbcf19e4b8c3cbaa05b000e","ref":"refs/heads/2024.1","pushedAt":"2024-06-28T13:54:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jethro-M","name":null,"path":"/Jethro-M","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/88681329?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][PLAT-14501] Fix NPE for non-dr xCluster config create error\n\nSummary:\nThis diff fixes an issue where create xCluster config failure for non-DR xCluster configs will cause a null pointer exception\ndue to an attempt to set DR state for a non-DR xCluster config.\n\nThis diff adds a check for DR usage before attempting to set DR error state on xCluster config creation failure.\n\nOriginal commit: 2cc10972214b3ce37f916494c0da941d532b0e9a / D36141\n\nTest Plan:\nCreate xCluster config and cause a failure (ex. stop target universe during creation)\nVerify that non-DR xCluster config creation failures do not cause a NPE by checking the platform logs.\n{F261012}\nVerify that xCluster DR config creation failures do set the DR state to `ERROR` and verify the expect log lines are printed.\n{F261011}\n{F261015}\n\nReviewers: cwang, hzare, sanketh\n\nReviewed By: cwang\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D36189","shortMessageHtmlLink":"[BACKPORT 2024.1][PLAT-14501] Fix NPE for non-dr xCluster config crea…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEclsmHQA","startCursor":null,"endCursor":null}},"title":"Activity · yugabyte/yugabyte-db"}