Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security vulnerability] Arbitrary Address Deletion Vulnerability #106

Open
GatekeeperBuster opened this issue May 5, 2023 · 0 comments

Comments

@GatekeeperBuster
Copy link

Recently, our team found an arbitrary address deletion vulnerability in the latest version of the project.

The vulnerability logic is present in the file: https://github.com/youlaitech/youlai-mall/blob/master/mall-ums/ums-boot/src/main/java/com/youlai/mall/ums/controller/app/AddressController.java#L63.

image

The operation addressService.removeByIds() is not protected by permission checks,
which allows a regular user to delete any users' addresses through a customized request to
DELETE /app-api/v1/addresses/{ids}.

To address this vulnerability, we strongly advise that developers implement access control policies that limit API access to admin users or the owner of the address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant