Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-components - update components to use toJafar hoc util #90

Open
galhavivi opened this issue Jul 27, 2020 · 0 comments
Open

react-components - update components to use toJafar hoc util #90

galhavivi opened this issue Jul 27, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@galhavivi
Copy link
Member

Update components in @jafar/react-components to use toJafar mapper util As described in
#86

A good reference -
https://github.com/yahoo/jafar/tree/master/packages/react-components/src/components/edit/Switch

Test
also update tests similar to - https://github.com/yahoo/jafar/blob/master/packages/react-components/src/test/edit/Switch.spec.js

md file - verify demos of the components:

  • all examples of the component work as expected
  • no console errors or warnings
  • description and import with link appear in the top of all examples
  • props & methods appear and show correct data - props and default props
@galhavivi galhavivi added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 27, 2020
@galhavivi galhavivi mentioned this issue Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@galhavivi