Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: make consumable as library #210

Open
cdaringe opened this issue Jun 10, 2020 · 3 comments
Open

rfc: make consumable as library #210

cdaringe opened this issue Jun 10, 2020 · 3 comments
Labels
enhancement New feature or request
Projects

Comments

@cdaringe
Copy link

Problem

I have a probot application, and want to tap into this functionality. However, this code is not distributed on npm.

Discussion

Can we:

  • publish to npm
  • export mappings between event-name:handler

in this regard, I can import pull and bind them to my existing event handlers

@MaxDesiatov
Copy link

Likewise, I wish there was a hosted version, maybe based on GitHub Actions?

@wei
Copy link
Owner

wei commented Aug 19, 2020

Great idea, I'll definitely consider it for a future release!

@cdaringe Do you have an example package on npm that provides event handler bindings for us to model after?

@MaxDesiatov Probot v11 has serverless deployments on its roadmap including GitHub Actions support. I'm looking forward to it!

@wei wei added the enhancement New feature or request label Aug 19, 2020
@cdaringe
Copy link
Author

Sure! https://github.com/cdaringe/semantic-pull-requests/blob/feat/publish/index.js

semantic exports a single function that takes the app and registers handlers. That's a great start! I'd advocate for finer grain control as well, just exporting the handler and letting us call into the handler. Maybe also export the default events that would be bound to it.

@wei wei added this to To do in Roadmap Aug 19, 2020
Repository owner deleted a comment Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Roadmap
  
To do
Development

No branches or pull requests

3 participants