Fix type of AuthenticatorAttestationResponseJSON.publicKeyAlgorithm #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2065. `AuthenticatorAttestationResponseJSON` was added in the L3 drafts, so we can easily change `AuthenticatorAttestationResponseJSON.publicKeyAlgorithm` to type `long` (or `COSEAlgorithmIdentifier`) since L3 isn't formally released yet. `AuthenticatorAttestationResponseJSON.publicKeyAlgorithm` is also in output (covariant) position, so changing its type to be more restrictive is even backwards compatible.
MasterKale
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2065.
AuthenticatorAttestationResponseJSONwas added in the L3 drafts, so we can easily changeAuthenticatorAttestationResponseJSON.publicKeyAlgorithmto typelong(orCOSEAlgorithmIdentifier) since L3 isn't formally released yet.AuthenticatorAttestationResponseJSON.publicKeyAlgorithmis also in output (covariant) position, so changing its type to be more restrictive is even backwards compatible.I misspoke on the 2024-05-15 call: I said the range of CBOR integers is any value whose size in bits can be represented by uint64_t. This was incorrect - uint64_t (2^64-1) is the max value range, not a value size range.
Preview | Diff