Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision default based on job unit #47

Open
voneiden opened this issue May 10, 2023 · 3 comments
Open

Precision default based on job unit #47

voneiden opened this issue May 10, 2023 · 3 comments
Labels
quality Achievement unlocked: Shoe polish

Comments

@voneiden
Copy link
Owner

Possibly 3 for imperial (0.001" / 0.0254 mm) and 2 for metric (0.01 mm / 0.0003").

@voneiden voneiden added the quality Achievement unlocked: Shoe polish label May 10, 2023
@giannissc
Copy link
Contributor

If I am not mistaken it is 3 dp for metric (mm) and 4dp for imperial (inch)

@voneiden
Copy link
Owner Author

Is this a reference to LinuxCNC docs?

Well, maybe just go with 3 and 4 for now. Later this should be tied to post-processor as well. And also have separate various precision values for fine control (interpolation, arc tolerance, clean).

grbl may already struggle to keep up with line segment lengths of 0.1 mm (depending on feedrate and acceleration), so universal default of 0.001 mm is not a good idea in the long term.

@giannissc
Copy link
Contributor

I don't remember where I saw it but I have all my files downloaded so I can search for it again. But I do agree that the post processor is probably the best place to include it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Achievement unlocked: Shoe polish
Projects
None yet
Development

No branches or pull requests

2 participants