Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type variable isAbstract setter is ambiguous #241

Open
dmitrii-ubskii opened this issue Oct 26, 2022 · 0 comments
Open

Type variable isAbstract setter is ambiguous #241

dmitrii-ubskii opened this issue Oct 26, 2022 · 0 comments
Assignees
@dmitrii-ubskii
Labels
priority: medium type: refactor

Comments

@dmitrii-ubskii
Copy link
Member

dmitrii-ubskii commented Oct 26, 2022 •
edited by flyingsilverfin
Loading

Problem to Solve

The setter TypeVariableBuilder.isAbstract() reads like it's an accessor that would return true if the TypeVariable in question has the Abstract type constraint, rather than setting the type variable to be abstract.

Proposed Solution

Rename to abstract_(). This change will probably propagate to at least TypeDB and TypeDB-Client.
@dmitrii-ubskii dmitrii-ubskii self-assigned this Oct 26, 2022
@dmitrii-ubskii dmitrii-ubskii mentioned this issue Oct 26, 2022
Merged
@flyingsilverfin flyingsilverfin changed the title Rename isAbstract builder method to abstract Type variable isAbstract setter is ambiguous Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitrii-ubskii dmitrii-ubskii

Labels
priority: medium type: refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flyingsilverfin @dmitrii-ubskii