fix: Pass the scope conditionally for OAuth2 Password Credentials #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same is true for other oauth2 grant types. Perhaps it's worth updating different ones as well? |
nicolasnobelis
force-pushed
the
bugfix/fix_password_grant_type
branch
4 times, most recently
from
30250d9
to
8ec912a
Compare
Fixes: usebruno#2446. Signed-off-by: Nicolas Nobelis <[email protected]>
nicolasnobelis
force-pushed
the
bugfix/fix_password_grant_type
branch
from
8ec912a
to
fd0ae57
Compare
lohxt1
approved these changes
Jun 18, 2024
|
Merged! Thanks for working on this @nicolasnobelis ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scope param is always passed (when according to the spec, it is optional).
The server responds with
{
"error": "invalid_scope",
"error_description": "Invalid scopes: "
}
Fixes: #2446.