Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2: The scope in case of Password Credentials grant type #2446

Closed
2 tasks done
nicolasnobelis opened this issue Jun 12, 2024 · 1 comment · Fixed by #2447
Closed
2 tasks done

OAuth2: The scope in case of Password Credentials grant type #2446

nicolasnobelis opened this issue Jun 12, 2024 · 1 comment · Fixed by #2447
Labels
bug Something isn't working

Comments

@nicolasnobelis
Copy link
Contributor

nicolasnobelis commented Jun 12, 2024 •
edited
Loading

I have checked the following:

  • I use the newest version of bruno.
  • I've searched existing issues and found nothing related to my issue.

Describe the bug

See attached screenshot:

The scope param is always passed (when according to the spec, it is optional).

The server responds with

{
  "error": "invalid_scope",
  "error_description": "Invalid scopes: "
}

This issue requires the same kind of fix as https://github.com/usebruno/bruno/pull/1807/files but for Password Credentials.

.bru file to reproduce the bug

No response

Screenshots/Live demo link

bruno_bug
@nicolasnobelis nicolasnobelis added the bug Something isn't working label Jun 12, 2024
@nicolasnobelis nicolasnobelis changed the title OAuth2: The scope in case of Password Credentailsgrant type OAuth2: The scope in case of Password Credentials grant type Jun 12, 2024
nicolasnobelis added a commit to nicolasnobelis/bruno that referenced this issue Jun 12, 2024
@nicolasnobelis @nnobelis
fix: Pass the scope conditionally for OAuth2 Password Credentials
8c96549 
Fixes: usebruno#2446.

Signed-off-by: Nicolas Nobelis <[email protected]>
nicolasnobelis pushed a commit to nicolasnobelis/bruno that referenced this issue Jun 12, 2024
@nnobelis
fix: Pass the scope conditionally for OAuth2 Password Credentials
ff52315 
Fixes: usebruno#2446.

Signed-off-by: Nicolas Nobelis <[email protected]>
@nicolasnobelis nicolasnobelis mentioned this issue Jun 12, 2024
Merged
nicolasnobelis pushed a commit to nicolasnobelis/bruno that referenced this issue Jun 13, 2024
@nnobelis
fix: Pass the scope conditionally for OAuth2 grant types
238a6d5 
Fixes: usebruno#2446.

Signed-off-by: Nicolas Nobelis <[email protected]>
nicolasnobelis added a commit to nicolasnobelis/bruno that referenced this issue Jun 13, 2024
@nicolasnobelis @nnobelis
fix: Pass the scope conditionally for OAuth2 grant types
df8fec7 
Fixes: usebruno#2446.

Signed-off-by: Nicolas Nobelis <[email protected]>
nicolasnobelis pushed a commit to nicolasnobelis/bruno that referenced this issue Jun 13, 2024
@nnobelis
fix: Pass the scope conditionally for OAuth2 grant types
30250d9 
Fixes: usebruno#2446.

Signed-off-by: Nicolas Nobelis <[email protected]>
nicolasnobelis added a commit to nicolasnobelis/bruno that referenced this issue Jun 13, 2024
@nicolasnobelis @nnobelis
fix: Pass the scope conditionally for OAuth2 grant types
8ec912a 
Fixes: usebruno#2446.

Signed-off-by: Nicolas Nobelis <[email protected]>
nicolasnobelis added a commit to nicolasnobelis/bruno that referenced this issue Jun 13, 2024
@nicolasnobelis
fix: Pass the scope conditionally for OAuth2 grant types
fd0ae57 
Fixes: usebruno#2446.

Signed-off-by: Nicolas Nobelis <[email protected]>
@helloanoop
Copy link
Contributor

The PR has been merged.
This is set to go out in the upcoming 1.20.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Pass the scope conditionally for OAuth2 Password Credentials nicolasnobelis/bruno
2 participants
@helloanoop @nicolasnobelis