Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Store client certificate paths in collection settings as relative to collection #2420

Open
1 task done
pietrygamat opened this issue Jun 6, 2024 · 1 comment · May be fixed by #2421
Open
1 task done
Labels
enhancement New feature or request

Comments

@pietrygamat
Copy link
Contributor

pietrygamat commented Jun 6, 2024

I have checked the following:

  • I've searched existing issues and found nothing related to my issue.

Describe the feature you want to add

The path to cert and key files stored in bruno.json file should be relative to collection.

Currenlty, when I pick up a cert or a key file in UI they are persisted as absolute paths on my disk, which is not git friendly, especially when the certificates are themselves part of my git repo. The path should also be normalized (to POSIX standard?), because we do not want to see these pesky \\ pollution from our Windows friends.

Note, bruno does not seem to have the problem when loading data like this, but should always save it this way.

Mockups or Images of the feature

This is good

"clientCertificates": {
   "enabled": true,
   "certs": [
     {
       "domain": "localhost",
       "certFilePath": "../certs/my.cer",
       "keyFilePath": "../certs/my.privkey.pem",
       "passphrase": ""
     },

This is bad

 "clientCertificates": {
    "enabled": true,
    "certs": [
      {
    "domain": "host.docker.internal",
        "certFilePath": "C:\\Users\\bruno\\Projects\\collections\\certs\\my.cer",
        "keyFilePath": "C:\\Users\\bruno\\Projects\\collections\\certs\\my.privkey.pem",
        "passphrase": ""
      },
@pietrygamat pietrygamat added the enhancement New feature or request label Jun 6, 2024
pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jun 6, 2024
@pidj
Copy link

pidj commented Jun 12, 2024

Kudos for this feature request. I'm interested by this feature too :-)

pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jun 12, 2024
pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jun 12, 2024
pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jun 21, 2024
pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jun 21, 2024
pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jun 21, 2024
pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jun 21, 2024
pietrygamat added a commit to pietrygamat/bruno that referenced this issue Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants