Depend on OpenJDK>8.0.0 for PySpark support #1701
Conversation
Add openjdk>8.0.0 to conda environment to fix failing PySpark code snippet Ignore openjdk in requirements.txt generation script Fix unstripped package names in requirements.txt builder script Signed-off-by: Billy Vinning <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1701 +/- ##
===========================================
- Coverage 94.28% 82.60% -11.68%
===========================================
Files 91 117 +26
Lines 7013 8715 +1702
===========================================
+ Hits 6612 7199 +587
- Misses 401 1516 +1115 ☔ View full report in Codecov by Sentry. |
|
thanks @billyvinning ! This change is purely for the docs right? If so, I think installing |
Use `install-jdk` to install OpenJDK 11 Temurin as part of CI extra tests and readthedocs env set up. Remove `openjdk` from environment.yaml Remove `openjdk` from exclusion list of pip deps generation script. Signed-off-by: Billy Vinning <[email protected]>
Yes, you're right. In that case, let's try using Since you mentioned it, I did the same with the |
Attempt to fix #1678.
A Java implementation (8/11/17) is required to run PySpark code snippets in the documentation, see #1678 for an example of a failing snippet. This change adds OpenJDK as a Conda dependency. Added OpenJDK to the list of packages to ignore when building the list of pip dependencies.