Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce systemd (WIP) #1537

Draft
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

MdSahil-oss
Copy link
Contributor

@MdSahil-oss MdSahil-oss commented Apr 10, 2024

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

GitHub-Closes: #1466

Comment on lines +463 to +471
// GetArgs returns all the arguments of run command as an array of strings.
func (opts *RunOptions) GetArgs() []string {
args := []string{}
if opts.Detach {
args = append(args, "--detach")
}
if opts.DisableAccel {
args = append(args, "--disable-acceleration")
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out: https://pkg.go.dev/reflect#StructTag.Get

This will simplify getting the flag name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it 👍🏽

@craciunoiuc
Copy link
Member

Hey @MdSahil-oss

Do you have an estimate for when you'll restart work on this? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement systemd unikernel manager
3 participants