Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Nested container check might be wrong #215

Open
cvrebert opened this issue Jan 10, 2015 · 1 comment · May be fixed by #255
Open

Nested container check might be wrong #215

cvrebert opened this issue Jan 10, 2015 · 1 comment · May be fixed by #255
Labels
bug

Comments

@cvrebert
Copy link
Collaborator

See twbs/bootstrap#15512 (comment)
Also, looks like the current check only looks for direct children rather than descendants?
@cvrebert cvrebert added the bug label Jan 10, 2015
@zacechola
Copy link
Collaborator

Bootstrap explicitly deals with navbar components within .container-fluid.

https://github.com/twbs/bootstrap/blob/8777803acfb364a7cf10ba809d451432a6aa0a3e/less/navbar.less#L107-L119

Presumably we could switch to use .find() rather than .children(), while allowing for an exception within .navbar.

$('.container, .container-fluid').find(':not(.navbar)').find('.container, .container-fluid')

I'm unaware of any other nested containers within bootstrap's docs/examples.

zacechola pushed a commit to zacechola/bootlint that referenced this issue Mar 2, 2015
Fix twbs#215
f8c1e92 
1. Ignore containers within `.navbar`
2. Expand search for more than just direct children.
@zacechola zacechola linked a pull request Mar 2, 2015 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly ignore containers within navbar for E004 zacechola/bootlint
2 participants
@cvrebert @zacechola