Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstalling a plugin don't remove the rate-limiter config from the table steampipe_plugin_limiter #4255

Open
ParthaI opened this issue Apr 24, 2024 · 1 comment
Labels
bug Something isn't working stale No recent activity has been detected on this issue/PR and it will be closed

Comments

@ParthaI
Copy link

ParthaI commented Apr 24, 2024

Describe the bug
After installing a plugin and configuring the rate limiter in the plugin.go file (refer to https://github.com/turbot/steampipe-plugin-aws/blob/main/aws/plugin.go#L51-L76), the corresponding rows are added to the steampipe_plugin_limiter table. However, these rows remain in the table even after the plugin is uninstalled.

Steampipe version (steampipe -v)
Example: v0.22.2

To reproduce
To replicate the issue, follow these steps using the existing PR branch (add-rate-limiter-config) in the GCP plugin:

  • Clone the repository: git clone [email protected]:turbot/steampipe-plugin-gcp.git
  • Navigate to the cloned directory: cd steampipe-plugin-gcp
  • Checkout the branch: git checkout add-rate-limiter-config
  • Build the plugin: make
  • Query the limiter table: select * from steampipe_plugin_limiter
  • Uninstall the GCP plugin and remove the .spc file.
  • Query the limiter table again: select * from steampipe_plugin_limiter
    Despite uninstalling, the rate limiter configuration rows are still visible.

Expected behavior
Uninstalling the plugin should remove any related rate limiter configurations from the table.

Additional context
Add any other context about the problem here.

@ParthaI ParthaI added the bug Something isn't working label Apr 24, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale No recent activity has been detected on this issue/PR and it will be closed
Projects
None yet
Development

No branches or pull requests

1 participant