Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce reference set of pe-parse - peparse::`dynamic initializer for 'ProductIdMap'' #188

Open
Alan-Jowett opened this issue Jul 17, 2023 · 1 comment

Comments

@Alan-Jowett
Copy link

This library has a dynamic initializer for ProductIdMap and ProductMap, which causes the process to allocate and commit 13 pages.

Ask:
Allocate these pages on demand.

Both of these objects are only used in parse.cpp and are used from GetRichProductName and GetRichObjectType.

Proposal:
Switch these to allocate these data structures on demand.

@woodruffw
Copy link
Member

Thanks for reporting @Alan-Jowett!

I can't promise any immediate availability to improve this, since the current version of the library is mostly in maintenance mode. That being said, I'd be happy to review a PR that changes the initialization behavior to on-demand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants