Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

burn-import: Add optional or configurable logging to generated burn graph #1879

Open
skewballfox opened this issue Jun 11, 2024 · 1 comment

Comments

@skewballfox
Copy link
Contributor

Feature description

Something that would be extremely useful in cases like #1877 is some kind of debug information on what operations are being called and what's being passed.

Feature motivation

When refactoring or working on burn-import, bugs became much harder to track once the ONNX graph was parseable. Some bugs only show up when attempting to compile the generated burn graph, and some when actually running it. Catching compile time errors during generation (ONNX graph parsed, burn code generated, compilation fails) is a much harder problem, but debug logging for generated models will make diagnosing runtime issues somewhat straightforward

(Optional) Suggest a Solution

either modify the macro we're using to include something like "if confingurable condition then log info" or add debug logs to all models (which should be excluded from release buillds)

@nathanielsimard
Copy link
Member

I think we can use the fusion backend to actually track all burn operations! It's already how we do our graph capture for compilation and works with all burn models, not just the ones imported using burn-import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants