Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image normalization #73

Open
Vuillecard opened this issue May 2, 2024 · 0 comments
Open

Image normalization #73

Vuillecard opened this issue May 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Vuillecard
Copy link

Hello,

Thank you for this project. It is very helpful. It seems to have a discrepancy in the normalization of the image. I noticed two potential issues:

  1. The detector retinaNnet applies some normalization which also affects the face crop data.face. Then, the normalization order should stay the same in the unifier to denormalize the face crop into [0,1]. Right now the face crop can have a negative value.
  2. The image is loaded with torchvision resulting in RGB images. From the RetinaNet implementation preprocessing the image is loaded in BGR format the mean they applied is (104, 117, 123). In facetorch, the transform is applied before rgbtobgr() thus I think that the correct order would be (123,117,104).

With the modification of point 1, all face crops are in [0,1]. For point 2 it is harder to check

@tomas-gajarsky tomas-gajarsky added the bug Something isn't working label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants