Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Homebrew release of OSS version "tel2oss" of Telepresence #3609

Open
tonur opened this issue Jun 7, 2024 · 1 comment · May be fixed by #3626
Open

Provide Homebrew release of OSS version "tel2oss" of Telepresence #3609

tonur opened this issue Jun 7, 2024 · 1 comment · May be fixed by #3626
Labels
t:feature New feature or enhancement request

Comments

@tonur
Copy link

tonur commented Jun 7, 2024

I have implemented a sample Homebrew formula for the "tel2oss" here: https://github.com/tonur/homebrew-telepresence-oss

Please describe your use case / problem.
Installing from a binary download link is not preferred, as the Telepresence install page for the standard release also suggests installation via brew.
My use case would be much improved if I could install the "tel2oss" version of Telepresence with such a command:
brew install datawire/blackbird/telepresence-oss

Describe the solution you'd like
Add the "tel2oss" as a separate Homebrew formula as part of the release build which currently uses packaging/homebrew-package.sh to only release the "tel2" standard version.

The best solution would be to host this Homebrew formula on a Datawire controlled repository, likely the current Homebrew tap location for this: https://github.com/datawire/homebrew-blackbird as a formula called "telepresence-oss".
As mentioned, this formula for the "tel2oss" can perhaps serve as inspiration: https://github.com/tonur/homebrew-telepresence-oss.
This requires changes to the packaging/homebrew-package.sh file to automate new releases.

Describe alternatives you've considered
Hosting the formula myself, but this is undesirable for other users, as a random Github users private repository is less trusted than the official Datawire controlled repository.

Versions (please complete the following information)

  • Output of telepresence version (just in case the feature exists in future versions)
> telepresence version
OSS Client     : v2.18.0
OSS Root Daemon: v2.18.0
OSS User Daemon: v2.18.0
Traffic Manager: v2.17.0
Traffic Agent  : not currently available
  • Kubernetes Environment and Version
    AKS Version 1.28

Additional context
This applies only to MacBook and perhaps Linux, as these are the only users of Homebrew.

@cindymullins-dw cindymullins-dw added the t:feature New feature or enhancement request label Jun 10, 2024
@tonur
Copy link
Author

tonur commented Jun 20, 2024

I could try my luck at adding this feature by modifying the same files as in #3282.
I can make a Pull Request this afternoon, if this is something Telepresence/DataWire is okay with.

@tonur tonur linked a pull request Jun 20, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:feature New feature or enhancement request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants