Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always uses default transition when using pushstate #2

Open
digitalgears opened this issue Jul 8, 2013 · 3 comments
Open

Always uses default transition when using pushstate #2

digitalgears opened this issue Jul 8, 2013 · 3 comments

Comments

@digitalgears
Copy link

When calculating the transition direction, the plugin always assumes url's are a hash. This means when using pushstate, the default transition always runs (i.e. no transition).

I suggest two new options are needed 'pushstate': true|false, 'appRoot': '/'

@techjacker
Copy link
Owner

I wasn't aware of this, thanks for letting me know.

I'll put it on the to do list. Although I haven't got much free time at the moment so it might take a while to get released in case you were relying on this urgently.

@digitalgears
Copy link
Author

No rush, just thought I'd bring to your attention. I have managed to work round it by just parsing in the direction.

There are also a few other things like the use of $.browser which has been deprecated in 1.9. I also made some changes to the way the container height gets calculated in case you only want to transition a small part of the page. It's probably a little to custom to warrant a pull request though.

Its a cool plugin btw :-)

@techjacker
Copy link
Owner

Cheers dude, if you fork and push those changes you mentioned then I'll try and get those in as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants