Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 error on removed elements #64

Open
niklashultstrom opened this issue May 8, 2017 · 2 comments
Open

IE11 error on removed elements #64

niklashultstrom opened this issue May 8, 2017 · 2 comments

Comments

@niklashultstrom
Copy link

Watchers with their watchItem removed by eg. $('.watched-element').remove() will run in to an error on IE11, when trying to access the .getBoundingClientRect()

@mahboob-awan
Copy link

mahboob-awan commented Mar 7, 2018

@stutrek: Can we check at: https://github.com/stutrek/scrollMonitor/blob/46993cd5eb48fc4bafa1d20d77c958dd09d11d35/src/watcher.js#L127 that if watchItem exist in DOM tree, otherwise skip the operations?

@stutrek
Copy link
Owner

stutrek commented Mar 8, 2018

If you send me a PR with a check I will accept it. I am very busy in my work and personal lives right now. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants