Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM format is not available since version 13 #626

Open
sd-git opened this issue May 23, 2024 · 2 comments
Open

ESM format is not available since version 13 #626

sd-git opened this issue May 23, 2024 · 2 comments

Comments

@sd-git
Copy link

sd-git commented May 23, 2024

After upgrading from version 11 I noticed missing directories (es6, es2020, esm) from the package distibution.

According to the code this was changed in the build of json-joy since version 13, what was the reason?

We were using json-joy 'esm' format along with Angular. After uprading to version 16 of json-joy, now we have to use '/lib', which is commonJS and Angular build gives complaints about potential optimization issues with 'commonJS library'.

Is there a way to fix this or any plans to provide esm as an option for json-joy package?

Thank you!

@streamich
Copy link
Owner

Hey! The reason for removing it was to simplify the build process and reduce the size of the downloaded NPM package. The idea was that ESM artifacts were not used much, if at all. But since you are bringing up this issue, it might have been not the case (we resume producing ESM artifacts in the future).

@sd-git
Copy link
Author

sd-git commented May 28, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants