Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider open sourcing our wrappers for onbackpresseddispatcher #1007

Open
rjrjr opened this issue Jun 2, 2023 · 2 comments
Open

Consider open sourcing our wrappers for onbackpresseddispatcher #1007

rjrjr opened this issue Jun 2, 2023 · 2 comments
Labels
ui Related to UI integration
Milestone

Comments

@rjrjr
Copy link
Contributor

rjrjr commented Jun 2, 2023

View.backPressedHandler and BackButtonScreen rely on everything being called in the right order across the entire view tree on every update. This is a fragile scheme.

@helios175 has been working on something in house that improves our ability to nest AndroidX back handlers, which would obviate this concern entirely. We should open source it. It fixes this problem, and is more battle tested than View.backPressedHandler.

@rjrjr rjrjr added this to the ui-1.0 milestone Jun 2, 2023
@rjrjr rjrjr added the ui Related to UI integration label Jun 2, 2023
@rjrjr
Copy link
Contributor Author

rjrjr commented Jul 13, 2023

We've learned OnBackPressedDispatcher better, and in particular its integration with Lifecycle, and now think it's good enough.

@rjrjr rjrjr closed this as completed Jul 13, 2023
@rjrjr rjrjr reopened this Jul 14, 2023
@rjrjr
Copy link
Contributor Author

rjrjr commented Jul 14, 2023

Closed this too soon, still murky waters. Why oh why can't we nest OnBackPressedDispatcher!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Related to UI integration
Projects
None yet
Development

No branches or pull requests

1 participant