Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does jadx produce different results even if .smali files remain unchanged? #2193

Open
lyubomyr-shaydariv opened this issue May 30, 2024 · 1 comment
Labels
bug Core Issues in jadx-core module

Comments

@lyubomyr-shaydariv
Copy link

lyubomyr-shaydariv commented May 30, 2024

Issue details

Hello.

I patch .smali files directly and I typically use jadx only to check whether my Smali patch is fine. But for some reason, jadx produces very different results even if no .smali files are changed right before decompiling .smali files over.

The jadx command I use is:

cmd.jadx \
	--add-debug-lines \
	--comments-level warn \
	--decompilation-mode restructure \
	--deobf \
	--no-imports \
	--output-dir-src "$APP_PACKAGE.$APP_VERSION_CODE.java.report" \
	--respect-bytecode-access-modifiers \
	--show-bad-code \
	--use-kotlin-methods-for-var-names apply \
	"$SMALI_DIR"

I had this issue in a previous version 1.4.7, but 1.5.0 seems to behave like that too. How stable, in terms of producing different results, the decompilation process is?

Relevant log output or stacktrace

🔴 For example, no .smali files changed, but decompiling produces:


 /* 486 */           foo.bar.base.p008a.AbstractC0454l m1625c = foo.bar.base.p008a.C0449g.m1625c(this.f1958a);
 /* 487 */           foo.bar.base.p008a.InterfaceC0457o m2575a = m2575a(m1625c);
                     try {
-                        switch (enumC0600e) {
-                            case READ:
+                        switch (foo.bar.base.service.C0744f.f1971a[enumC0600e.ordinal()]) {
+                            case 1:
 /* 492 */                       m1625c.mo1348a(this.f1958a, m2575a, strArr, l);
                                 break;
-                            case UNREAD:
+                            case 2:
 /* 495 */                       m1625c.mo1351b(this.f1958a, m2575a, strArr, l);
                                 break;
-                            case STARRED:
+                            case 3:
 /* 498 */                       m1625c.mo1353c(this.f1958a, m2575a, strArr, l);
                                 break;
-                            case UNSTARRED:
+                            case 4:
 /* 501 */                       m1625c.mo1355d(this.f1958a, m2575a, strArr, l);
                                 break;
                         }


🔴 Next one, let's say after changing the thread count it became (please note that enums switch reverted back but it also changed a lot of code too):

```diff
 /* 279 */       private void m801d(java.lang.String str) {
                     java.lang.String substring;
+                    com.p005b.p006a.CallableC0258b callableC0258b = null;
 /* 280 */           int indexOf = str.indexOf(32);
 /* 281 */           if (indexOf == -1) {
 /* 282 */               throw new java.io.IOException("unexpected journal line: " + str);
@@ -126,41 +127,34 @@
                     }
 /* 298 */           com.p005b.p006a.C0262f c0262f = (com.p005b.p006a.C0262f) this.f536l.get(substring);
 /* 299 */           if (c0262f == null) {
-/* 300 */               c0262f = new com.p005b.p006a.C0262f(this, substring, null);
+/* 300 */               c0262f = new com.p005b.p006a.C0262f(this, substring, callableC0258b);
 /* 301 */               this.f536l.put(substring, c0262f);
                     }
 /* 304 */           if (indexOf2 != -1 && indexOf == "CLEAN".length() && str.startsWith("CLEAN")) {
 /* 305 */               java.lang.String[] split = str.substring(indexOf2 + 1).split(" ");
-/* 875 */               c0262f.f550d = true;
-/* 875 */               c0262f.f551e = null;
-/* 875 */               c0262f.m828a(split);
+/* 306 */               com.p005b.p006a.C0262f.m829a(c0262f, true);
+/* 307 */               com.p005b.p006a.C0262f.m826a(c0262f, (com.p005b.p006a.C0260d) null);
+/* 308 */               com.p005b.p006a.C0262f.m827a(c0262f, split);
 /* 316 */               return;
                     }
-/* 309 */           if (indexOf2 != -1 || indexOf != "DIRTY".length() || !str.startsWith("DIRTY")) {
-/* 311 */               if (indexOf2 != -1 || indexOf != "READ".length() || !str.startsWith("READ")) {
-/* 314 */                   throw new java.io.IOException("unexpected journal line: " + str);
-                        }
-/* 316 */               return;
+/* 309 */           if (indexOf2 == -1 && indexOf == "DIRTY".length() && str.startsWith("DIRTY")) {
+/* 310 */               com.p005b.p006a.C0262f.m826a(c0262f, new com.p005b.p006a.C0260d(this, c0262f, callableC0258b));
+                    } else if (indexOf2 != -1 || indexOf != "READ".length() || !str.startsWith("READ")) {
+/* 314 */               throw new java.io.IOException("unexpected journal line: " + str);
                     }
-/* 875 */           c0262f.f551e = new com.p005b.p006a.C0260d(this, c0262f, null);
                 }
 
 /* 322 */       private void m806f() {
-                    com.p005b.p006a.C0260d c0260d;
-                    long[] jArr;
 /* 323 */           m795a(this.f529e);
 /* 324 */           java.util.Iterator it2 = this.f536l.values().iterator();
                     while (it2.hasNext()) {
 /* 325 */               com.p005b.p006a.C0262f c0262f = (com.p005b.p006a.C0262f) it2.next();
-/* 875 */               c0260d = c0262f.f551e;
-                        if (c0260d == null) {
+/* 326 */               if (com.p005b.p006a.C0262f.m825a(c0262f) == null) {
 /* 327 */                   for (int i = 0; i < this.f533i; i++) {
-/* 328 */                       long j = this.f534j;
-/* 875 */                       jArr = c0262f.f549c;
-                                this.f534j = j + jArr[i];
+                                this.f534j += com.p005b.p006a.C0262f.m831b(c0262f)[i];
                             }
                         } else {
-/* 875 */                   c0262f.f551e = null;
+/* 331 */                   com.p005b.p006a.C0262f.m826a(c0262f, (com.p005b.p006a.C0260d) null);
 /* 332 */                   for (int i2 = 0; i2 < this.f533i; i2++) {
 /* 333 */                       m795a(c0262f.m835a(i2));
 /* 334 */                       m795a(c0262f.m837b(i2));
@@ -171,9 +165,6 @@
                 }
 
 /* 345 */       public synchronized void m807g() {
-                    com.p005b.p006a.C0260d c0260d;
-                    java.lang.String str;
-                    java.lang.String str2;
                     if (this.f535k != null) {
 /* 347 */               this.f535k.close();
                     }
@@ -189,15 +180,10 @@
 /* 360 */               bufferedWriter.write("\n");
 /* 361 */               bufferedWriter.write("\n");
                         for (com.p005b.p006a.C0262f c0262f : this.f536l.values()) {
-/* 875 */                   c0260d = c0262f.f551e;
-                            if (c0260d != null) {
-/* 365 */                       java.lang.StringBuilder append = new java.lang.StringBuilder().append("DIRTY ");
-/* 875 */                       str = c0262f.f548b;
-                                bufferedWriter.write(append.append(str).append('\n').toString());
+/* 364 */                   if (com.p005b.p006a.C0262f.m825a(c0262f) != null) {
+/* 365 */                       bufferedWriter.write("DIRTY " + com.p005b.p006a.C0262f.m832c(c0262f) + '\n');
                             } else {
-/* 367 */                       java.lang.StringBuilder append2 = new java.lang.StringBuilder().append("CLEAN ");
-/* 875 */                       str2 = c0262f.f548b;
-                                bufferedWriter.write(append2.append(str2).append(c0262f.m836a()).append('\n').toString());
+/* 367 */                       bufferedWriter.write("CLEAN " + com.p005b.p006a.C0262f.m832c(c0262f) + c0262f.m836a() + '\n');
                             }
                         }
 /* 371 */               bufferedWriter.close();
@@ -229,40 +215,32 @@
                 }
 
 /* 404 */       public synchronized com.p005b.p006a.C0263g m811a(java.lang.String str) {
-                    boolean z;
                     com.p005b.p006a.C0263g c0263g;
-                    long j;
-                    long[] jArr;
                     m809i();
 /* 406 */           m804e(str);
 /* 407 */           com.p005b.p006a.C0262f c0262f = (com.p005b.p006a.C0262f) this.f536l.get(str);
 /* 408 */           if (c0262f == null) {
                         c0263g = null;
-                    } else {
-/* 875 */               z = c0262f.f550d;
-                        if (z) {
-/* 419 */                   java.io.InputStream[] inputStreamArr = new java.io.InputStream[this.f533i];
-/* 421 */                   for (int i = 0; i < this.f533i; i++) {
-                                try {
-/* 422 */                           inputStreamArr[i] = new java.io.FileInputStream(c0262f.m835a(i));
-                                } catch (java.io.FileNotFoundException e) {
-/* 426 */                           for (int i2 = 0; i2 < this.f533i && inputStreamArr[i2] != null; i2++) {
-/* 428 */                               com.p005b.p006a.C0266j.m842a(inputStreamArr[i2]);
-                                    }
-                                    c0263g = null;
+                    } else if (com.p005b.p006a.C0262f.m833d(c0262f)) {
+/* 419 */               java.io.InputStream[] inputStreamArr = new java.io.InputStream[this.f533i];
+/* 421 */               for (int i = 0; i < this.f533i; i++) {
+                            try {
+/* 422 */                       inputStreamArr[i] = new java.io.FileInputStream(c0262f.m835a(i));
+                            } catch (java.io.FileNotFoundException e) {
+/* 426 */                       for (int i2 = 0; i2 < this.f533i && inputStreamArr[i2] != null; i2++) {
+/* 428 */                           com.p005b.p006a.C0266j.m842a(inputStreamArr[i2]);
                                 }
+                                c0263g = null;
                             }
-                            this.f537m++;
-/* 437 */                   this.f535k.append((java.lang.CharSequence) ("READ " + str + '\n'));
-/* 438 */                   if (m808h()) {
-/* 439 */                       this.f526b.submit(this.f539o);
-                            }
-/* 875 */                   j = c0262f.f552f;
-/* 875 */                   jArr = c0262f.f549c;
-/* 442 */                   c0263g = new com.p005b.p006a.C0263g(this, str, j, inputStreamArr, jArr, null);
-                        } else {
-                            c0263g = null;
                         }
+                        this.f537m++;
+/* 437 */               this.f535k.append((java.lang.CharSequence) ("READ " + str + '\n'));
+/* 438 */               if (m808h()) {
+/* 439 */                   this.f526b.submit(this.f539o);
+                        }
+/* 442 */               c0263g = new com.p005b.p006a.C0263g(this, str, com.p005b.p006a.C0262f.m834e(c0262f), inputStreamArr, com.p005b.p006a.C0262f.m831b(c0262f), null);
+                    } else {
+                        c0263g = null;
                     }
                     return c0263g;
                 }
@@ -271,44 +249,30 @@
 /* 450 */           return m791a(str, -1L);
                 }
 
-                /* JADX WARN: Code restructure failed: missing block: B:9:0x001e, code lost:
-                
-                    if (r2 != r6) goto L36;
-                 */
-                /*
-                    Code decompiled incorrectly, please refer to instructions dump.
-                */
 /* 453 */       private synchronized com.p005b.p006a.C0260d m791a(java.lang.String str, long j) {
-                    com.p005b.p006a.C0260d c0260d;
                     com.p005b.p006a.C0262f c0262f;
-                    com.p005b.p006a.C0260d c0260d2;
-                    long j2;
+                    com.p005b.p006a.C0260d c0260d;
                     m809i();
 /* 455 */           m804e(str);
 /* 456 */           com.p005b.p006a.C0262f c0262f2 = (com.p005b.p006a.C0262f) this.f536l.get(str);
-                    if (j != -1) {
-                        if (c0262f2 != null) {
-/* 875 */                   j2 = c0262f2.f552f;
-                        }
-                        c0260d2 = null;
-                    }
-/* 461 */           if (c0262f2 == null) {
-/* 462 */               com.p005b.p006a.C0262f c0262f3 = new com.p005b.p006a.C0262f(this, str, null);
-/* 463 */               this.f536l.put(str, c0262f3);
-                        c0262f = c0262f3;
-                    } else {
-/* 875 */               c0260d = c0262f2.f551e;
-                        if (c0260d != null) {
-                            c0260d2 = null;
+                    if (j == -1 || (c0262f2 != null && com.p005b.p006a.C0262f.m834e(c0262f2) == j)) {
+/* 461 */               if (c0262f2 == null) {
+/* 462 */                   com.p005b.p006a.C0262f c0262f3 = new com.p005b.p006a.C0262f(this, str, null);
+/* 463 */                   this.f536l.put(str, c0262f3);
+                            c0262f = c0262f3;
+                        } else if (com.p005b.p006a.C0262f.m825a(c0262f2) != null) {
+                            c0260d = null;
                         } else {
                             c0262f = c0262f2;
                         }
+/* 468 */               c0260d = new com.p005b.p006a.C0260d(this, c0262f, null);
+/* 469 */               com.p005b.p006a.C0262f.m826a(c0262f, c0260d);
+/* 472 */               this.f535k.write("DIRTY " + str + '\n');
+/* 473 */               this.f535k.flush();
+                    } else {
+                        c0260d = null;
                     }
-/* 468 */           c0260d2 = new com.p005b.p006a.C0260d(this, c0262f, null);
-/* 875 */           c0262f.f551e = c0260d2;
-/* 472 */           this.f535k.write("DIRTY " + str + '\n');
-/* 473 */           this.f535k.flush();
-                    return c0260d2;
+                    return c0260d;
                 }
 
 /* 478 */       public java.io.File m812a() {
@@ -316,49 +280,32 @@
                 }
 
 /* 508 */       public synchronized void m794a(com.p005b.p006a.C0260d c0260d, boolean z) {
-                    com.p005b.p006a.C0262f c0262f;
-                    com.p005b.p006a.C0260d c0260d2;
-                    boolean z2;
-                    java.lang.String str;
-                    java.lang.String str2;
-                    java.lang.String str3;
-                    long[] jArr;
-                    long[] jArr2;
-                    boolean z3;
-                    boolean[] zArr;
                     synchronized (this) {
-/* 721 */               c0262f = c0260d.f542b;
-/* 875 */               c0260d2 = c0262f.f551e;
-                        if (c0260d2 != c0260d) {
+                        com.p005b.p006a.C0262f m818a = com.p005b.p006a.C0260d.m818a(c0260d);
+/* 510 */               if (com.p005b.p006a.C0262f.m825a(m818a) != c0260d) {
 /* 511 */                   throw new java.lang.IllegalStateException();
                         }
-/* 515 */               if (z) {
-/* 875 */                   z3 = c0262f.f550d;
-                            if (!z3) {
-/* 516 */                       for (int i = 0; i < this.f533i; i++) {
-/* 721 */                           zArr = c0260d.f543c;
-                                    if (!zArr[i]) {
-/* 518 */                               c0260d.m823b();
-/* 519 */                               throw new java.lang.IllegalStateException("Newly created entry didn't create value for index " + i);
-                                    }
-/* 521 */                           if (!c0262f.m837b(i).exists()) {
-/* 522 */                               c0260d.m823b();
-                                        break;
-                                    }
+/* 515 */               if (z && !com.p005b.p006a.C0262f.m833d(m818a)) {
+/* 516 */                   for (int i = 0; i < this.f533i; i++) {
+/* 517 */                       if (!com.p005b.p006a.C0260d.m820b(c0260d)[i]) {
+/* 518 */                           c0260d.m823b();
+/* 519 */                           throw new java.lang.IllegalStateException("Newly created entry didn't create value for index " + i);
+                                }
+/* 521 */                       if (!m818a.m837b(i).exists()) {
+/* 522 */                           c0260d.m823b();
+                                    break;
                                 }
                             }
                         }
 /* 528 */               for (int i2 = 0; i2 < this.f533i; i2++) {
-/* 529 */                   java.io.File m837b = c0262f.m837b(i2);
+/* 529 */                   java.io.File m837b = m818a.m837b(i2);
 /* 530 */                   if (z) {
 /* 531 */                       if (m837b.exists()) {
-/* 532 */                           java.io.File m835a = c0262f.m835a(i2);
+/* 532 */                           java.io.File m835a = m818a.m835a(i2);
 /* 533 */                           m837b.renameTo(m835a);
-/* 875 */                           jArr = c0262f.f549c;
-                                    long j = jArr[i2];
+/* 534 */                           long j = com.p005b.p006a.C0262f.m831b(m818a)[i2];
 /* 535 */                           long length = m835a.length();
-/* 875 */                           jArr2 = c0262f.f549c;
-                                    jArr2[i2] = length;
+/* 536 */                           com.p005b.p006a.C0262f.m831b(m818a)[i2] = length;
 /* 537 */                           this.f534j = (this.f534j - j) + length;
                                 }
                             } else {
@@ -366,27 +313,18 @@
                             }
                         }
                         this.f537m++;
-/* 875 */               c0262f.f551e = null;
-/* 875 */               z2 = c0262f.f550d;
-                        if (!(z2 | z)) {
-/* 553 */                   java.util.LinkedHashMap linkedHashMap = this.f536l;
-/* 875 */                   str = c0262f.f548b;
-                            linkedHashMap.remove(str);
-/* 554 */                   java.io.Writer writer = this.f535k;
-                            java.lang.StringBuilder append = new java.lang.StringBuilder().append("REMOVE ");
-/* 875 */                   str2 = c0262f.f548b;
-                            writer.write(append.append(str2).append('\n').toString());
-                        } else {
-/* 875 */                   c0262f.f550d = true;
-/* 548 */                   java.io.Writer writer2 = this.f535k;
-                            java.lang.StringBuilder append2 = new java.lang.StringBuilder().append("CLEAN ");
-/* 875 */                   str3 = c0262f.f548b;
-                            writer2.write(append2.append(str3).append(c0262f.m836a()).append('\n').toString());
+/* 545 */               com.p005b.p006a.C0262f.m826a(m818a, (com.p005b.p006a.C0260d) null);
+/* 546 */               if (com.p005b.p006a.C0262f.m833d(m818a) | z) {
+/* 547 */                   com.p005b.p006a.C0262f.m829a(m818a, true);
+/* 548 */                   this.f535k.write("CLEAN " + com.p005b.p006a.C0262f.m832c(m818a) + m818a.m836a() + '\n');
 /* 549 */                   if (z) {
 /* 550 */                       long j2 = this.f538n;
                                 this.f538n = 1 + j2;
-/* 875 */                       c0262f.f552f = j2;
+                                com.p005b.p006a.C0262f.m824a(m818a, j2);
                             }
+                        } else {
+/* 553 */                   this.f536l.remove(com.p005b.p006a.C0262f.m832c(m818a));
+/* 554 */                   this.f535k.write("REMOVE " + com.p005b.p006a.C0262f.m832c(m818a) + '\n');
                         }
 /* 556 */               this.f535k.flush();
                         if (this.f534j > this.f532h || m808h()) {
@@ -401,37 +339,29 @@
 
 /* 579 */       public synchronized boolean m816c(java.lang.String str) {
                     boolean z;
-                    com.p005b.p006a.C0260d c0260d;
-                    long[] jArr;
-                    long[] jArr2;
                     synchronized (this) {
                         m809i();
 /* 581 */               m804e(str);
 /* 582 */               com.p005b.p006a.C0262f c0262f = (com.p005b.p006a.C0262f) this.f536l.get(str);
-/* 583 */               if (c0262f != null) {
-/* 875 */                   c0260d = c0262f.f551e;
-                            if (c0260d == null) {
-                                for (int i = 0; i < this.f533i; i++) {
-/* 588 */                           java.io.File m835a = c0262f.m835a(i);
-/* 589 */                           if (m835a.exists() && !m835a.delete()) {
-/* 590 */                               throw new java.io.IOException("failed to delete " + m835a);
-                                    }
-/* 592 */                           long j = this.f534j;
-/* 875 */                           jArr = c0262f.f549c;
-                                    this.f534j = j - jArr[i];
-/* 875 */                           jArr2 = c0262f.f549c;
-                                    jArr2[i] = 0;
+/* 583 */               if (c0262f == null || com.p005b.p006a.C0262f.m825a(c0262f) != null) {
+                            z = false;
+                        } else {
+                            for (int i = 0; i < this.f533i; i++) {
+/* 588 */                       java.io.File m835a = c0262f.m835a(i);
+/* 589 */                       if (m835a.exists() && !m835a.delete()) {
+/* 590 */                           throw new java.io.IOException("failed to delete " + m835a);
                                 }
-                                this.f537m++;
-/* 597 */                       this.f535k.append((java.lang.CharSequence) ("REMOVE " + str + '\n'));
-/* 598 */                       this.f536l.remove(str);
-/* 600 */                       if (m808h()) {
-/* 601 */                           this.f526b.submit(this.f539o);
-                                }
-/* 604 */                       z = true;
+                                this.f534j -= com.p005b.p006a.C0262f.m831b(c0262f)[i];
+/* 593 */                       com.p005b.p006a.C0262f.m831b(c0262f)[i] = 0;
+                            }
+                            this.f537m++;
+/* 597 */                   this.f535k.append((java.lang.CharSequence) ("REMOVE " + str + '\n'));
+/* 598 */                   this.f536l.remove(str);
+/* 600 */                   if (m808h()) {
+/* 601 */                       this.f526b.submit(this.f539o);
                             }
+/* 604 */                   z = true;
                         }
-                        z = false;
                     }
                     return z;
                 }
@@ -450,16 +380,12 @@
 
                 @Override
 /* 626 */       public synchronized void close() {
-                    com.p005b.p006a.C0260d c0260d;
-                    com.p005b.p006a.C0260d c0260d2;
                     if (this.f535k != null) {
 /* 630 */               java.util.Iterator it2 = new java.util.ArrayList(this.f536l.values()).iterator();
                         while (it2.hasNext()) {
                             com.p005b.p006a.C0262f c0262f = (com.p005b.p006a.C0262f) it2.next();
-/* 875 */                   c0260d = c0262f.f551e;
-                            if (c0260d != null) {
-/* 875 */                       c0260d2 = c0262f.f551e;
-                                c0260d2.m823b();
+/* 631 */                   if (com.p005b.p006a.C0262f.m825a(c0262f) != null) {
+/* 632 */                       com.p005b.p006a.C0262f.m825a(c0262f).m823b();
                             }
                         }
 /* 635 */               m810j();

@@ -26,15 +26,24 @@
 
 /* 726 */       private C0260d(com.p005b.p006a.C0257a c0257a, com.p005b.p006a.C0262f c0262f) {
                     boolean z;
+                    int i;
+                    boolean[] zArr;
 /* 727 */           this.f541a = c0257a;
 /* 728 */           this.f542b = c0262f;
 /* 875 */           z = c0262f.f550d;
-/* 88 */            this.f543c = z ? null : new boolean[c0257a.f533i];
+                    if (z) {
+                        zArr = null;
+                    } else {
+/* 88 */                i = c0257a.f533i;
+                        zArr = new boolean[i];
+                    }
+                    this.f543c = zArr;
                 }
 
 /* 768 */       public java.io.OutputStream m821a(int i) {
                     com.p005b.p006a.C0260d c0260d;
                     boolean z;
+                    java.io.File file;
                     java.io.OutputStream outputStream;
                     java.io.FileOutputStream fileOutputStream;
                     synchronized (this.f541a) {
@@ -50,7 +59,8 @@
                         try {
 /* 779 */                   fileOutputStream = new java.io.FileOutputStream(m837b);
                         } catch (java.io.FileNotFoundException e) {
-/* 88 */                    this.f541a.f527c.mkdirs();
+/* 88 */                    file = this.f541a.f527c;
+                            file.mkdirs();
                             try {
 /* 784 */                       fileOutputStream = new java.io.FileOutputStream(m837b);
                             } catch (java.io.FileNotFoundException e2) {
@@ -18,10 +18,51 @@
 /* 875 */           this(c0257a, str);
                 }
 
+/* 874 */       static long m824a(com.p005b.p006a.C0262f c0262f, long j) {
+/* 875 */           c0262f.f552f = j;
+                    return j;
+                }
+
+/* 874 */       static com.p005b.p006a.C0260d m825a(com.p005b.p006a.C0262f c0262f) {
+/* 875 */           return c0262f.f551e;
+                }
+
+/* 874 */       static com.p005b.p006a.C0260d m826a(com.p005b.p006a.C0262f c0262f, com.p005b.p006a.C0260d c0260d) {
+/* 875 */           c0262f.f551e = c0260d;
+                    return c0260d;
+                }
+
+/* 874 */       static void m827a(com.p005b.p006a.C0262f c0262f, java.lang.String[] strArr) {
+/* 875 */           c0262f.m828a(strArr);
+                }
+
+/* 874 */       static boolean m829a(com.p005b.p006a.C0262f c0262f, boolean z) {
+/* 875 */           c0262f.f550d = z;
+                    return z;
+                }
+
+/* 874 */       static long[] m831b(com.p005b.p006a.C0262f c0262f) {
+/* 875 */           return c0262f.f549c;
+                }
+
+/* 874 */       static java.lang.String m832c(com.p005b.p006a.C0262f c0262f) {
+/* 875 */           return c0262f.f548b;
+                }
+
+/* 874 */       static boolean m833d(com.p005b.p006a.C0262f c0262f) {
+/* 875 */           return c0262f.f550d;
+                }
+
+/* 874 */       static long m834e(com.p005b.p006a.C0262f c0262f) {
+/* 875 */           return c0262f.f552f;
+                }
+
 /* 889 */       private C0262f(com.p005b.p006a.C0257a c0257a, java.lang.String str) {
+                    int i;
 /* 890 */           this.f547a = c0257a;
 /* 891 */           this.f548b = str;
-/* 88 */            this.f549c = new long[c0257a.f533i];
+/* 88 */            i = c0257a.f533i;
+                    this.f549c = new long[i];
                 }
 
 /* 895 */       public java.lang.String m836a() {

@@ -33,12 +74,15 @@
                 }
 
 /* 904 */       public void m828a(java.lang.String[] strArr) {
-/* 88 */            if (strArr.length != this.f547a.f533i) {
+                    int i;
+/* 905 */           int length = strArr.length;
+/* 88 */            i = this.f547a.f533i;
+                    if (length != i) {
 /* 906 */               throw m830b(strArr);
                     }
-                    for (int i = 0; i < strArr.length; i++) {
+                    for (int i2 = 0; i2 < strArr.length; i2++) {
                         try {
-/* 911 */                   this.f549c[i] = java.lang.Long.parseLong(strArr[i]);
+/* 911 */                   this.f549c[i2] = java.lang.Long.parseLong(strArr[i2]);
                         } catch (java.lang.NumberFormatException e) {
 /* 914 */                   throw m830b(strArr);
                         }
@@ -50,10 +94,14 @@
                 }
 
 /* 922 */       public java.io.File m835a(int i) {
-/* 923 */           return new java.io.File(this.f547a.f527c, this.f548b + "." + i);
+                    java.io.File file;
+/* 88 */            file = this.f547a.f527c;
+/* 923 */           return new java.io.File(file, this.f548b + "." + i);
                 }
 
 /* 926 */       public java.io.File m837b(int i) {
-/* 927 */           return new java.io.File(this.f547a.f527c, this.f548b + "." + i + ".tmp");
+                    java.io.File file;
+/* 88 */            file = this.f547a.f527c;
+/* 927 */           return new java.io.File(file, this.f548b + "." + i + ".tmp");
                 }
             }

@@ -10,12 +10,16 @@
 
                 @Override
 /* 165 */       public java.lang.Void call() {
+                    java.io.Writer writer;
+                    boolean m808h;
                     synchronized (this.f540a) {
-/* 167 */               if (com.p005b.p006a.C0257a.m792a(this.f540a) != null) {
-/* 170 */                   com.p005b.p006a.C0257a.m797b(this.f540a);
-/* 171 */                   if (com.p005b.p006a.C0257a.m798c(this.f540a)) {
-/* 172 */                       com.p005b.p006a.C0257a.m800d(this.f540a);
-/* 173 */                       com.p005b.p006a.C0257a.m789a(this.f540a, 0);
+/* 88 */                writer = this.f540a.f535k;
+                        if (writer != null) {
+/* 88 */                    this.f540a.m810j();
+/* 88 */                    m808h = this.f540a.m808h();
+                            if (m808h) {
+/* 88 */                        this.f540a.m807g();
+/* 88 */                        this.f540a.f537m = 0;
                             }
                         }
                     }

@@ -207,17 +207,17 @@
 /* 486 */           foo.bar.base.p008a.AbstractC0454l m1625c = foo.bar.base.p008a.C0449g.m1625c(this.f1958a);
 /* 487 */           foo.bar.base.p008a.InterfaceC0457o m2575a = m2575a(m1625c);
                     try {
-                        switch (foo.bar.base.service.C0744f.f1971a[enumC0600e.ordinal()]) {
-                            case 1:
+                        switch (enumC0600e) {
+                            case READ:
 /* 492 */                       m1625c.mo1348a(this.f1958a, m2575a, strArr, l);
                                 break;
-                            case 2:
+                            case UNREAD:
 /* 495 */                       m1625c.mo1351b(this.f1958a, m2575a, strArr, l);
                                 break;
-                            case 3:
+                            case STARRED:
 /* 498 */                       m1625c.mo1353c(this.f1958a, m2575a, strArr, l);
                                 break;
-                            case 4:
+                            case UNSTARRED:
 /* 501 */                       m1625c.mo1355d(this.f1958a, m2575a, strArr, l);
                                 break;
                         }


### Provide sample and class/method full name

N/A

### Jadx version

1.4.7, 1.5.0
@lyubomyr-shaydariv lyubomyr-shaydariv added bug Core Issues in jadx-core module labels May 30, 2024
@lyubomyr-shaydariv
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core Issues in jadx-core module
Projects
None yet
Development

No branches or pull requests

1 participant