fix(dom.js): added support for nextjs #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for nextjs by fixing error "document is not defined" when used in a nextjs application fix #80
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Kindly review @shshaw & @notoriousb1t . |
shshaw
reviewed
May 3, 2024
src/utils/dom.js
Outdated
| @@ -61,5 +61,5 @@ export function $(e, parent) { | |||
| ? // a single element is wrapped in an array | |||
| [e] | |||
| : // selector and NodeList are converted to Element[] | |||
| [].slice.call(e[0].nodeName ? e : (parent || root).querySelectorAll(e)); | |||
| [].slice.call(e[0].nodeName ? e : document.querySelectorAll(e)); | |||
There was a problem hiding this comment.
How does this fix "Document not defined?" This is also a departure from the expected logic that finds the elements inside a parent if one is provided.
There was a problem hiding this comment.
As far as I can tell, this is the only logic change. If there's something I missed, do let me know. In the future, try to scope PRs to more focused changes so real changes are more apparent.
Added "(parent || document)" in the place of "document" to find the element inside a parent if one is provided
|
Kindly resolve the "Document not defined" error as it's a big issue with using your package with nextjs. Works on my end as implemented in my latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for nextjs by fixing error "document is not defined" when used in a nextjs application
Also added build support for ES6+ using terser
fix #80