New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asserting a request is sent by closure parameter #417

Closed

innocenzi opened this issue May 22, 2024 · 1 comment · May be fixed by #424

innocenzi commented May 22, 2024

Take the following snippet:

MockClient::getGlobal()->assertSent(function (CreateDealRequest $request) {
    expect($request->body()->all())->toMatchArray([
        'title' => '[MGT] Jon Doe / foo - bar / ' . now()->addDay()->format('M d \'y'),
        'status' => DealStatus::OPEN,
    ]);
});

This would fail if there was a request other than CreateDealRequest. It would be great if assertSent could take the request type into account.

Open to PRing that 👍

The text was updated successfully, but these errors were encountered:

innocenzi mentioned this issue

feat(testing): accept type-hinted requests as assertSent parameters #424

Open

Collaborator

Sammyjo20 commented Jun 26, 2024

Thank you for PRing this! I'm going to close this as it's now a PR.

Sammyjo20 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment