Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: dashboard not using all settings field in query (Can't set limitQuantityPerCheckout) #4948

Open
djkato opened this issue Jun 11, 2024 · 0 comments
Labels
bug Something isn't working triage

Comments

@djkato
Copy link
Contributor

djkato commented Jun 11, 2024

Description of the issue

In dashboard, setting the limitQuantityPerCheckout doesn't do anything. The UI pretends it was set on refresh, but when I go to other page and back to settings, the number is back to default. That's because the variable isn't present in the ShopSettingsUpdate mutation.
I think the problematic line is: https://github.com/saleor/saleor-dashboard/blob/main/src/siteSettings/views/index.tsx#L67
image

Also, I have set the env variable MAX_CHECKOUT_LINE_QUANTITY=200 for Saleor, but it doesn't do anything.

Steps to reproduce the problem

Try to set dashboard variable.

What did you expect to happen?

The variable to change from default.

Additional information

https://github.com/saleor/saleor-dashboard/blob/main/src/siteSettings/views/index.tsx#L67 add that variable here I think.

Environment

Browser and version: Firefox 126.0.1 (64-bit)
OS and version: Linux
dashboard v3.19.6
core v3.19.38

@djkato djkato added bug Something isn't working triage labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
Status: No status
Development

No branches or pull requests

1 participant