Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign team member who proposed fcp #317

Open
tmandry opened this issue Oct 18, 2023 · 1 comment
Open

Assign team member who proposed fcp #317

tmandry opened this issue Oct 18, 2023 · 1 comment

Comments

@tmandry
Copy link
Member

tmandry commented Oct 18, 2023

I found it really helpful when @dtolnay assigned me to rust-lang/rust#115333 after I proposed fcp merge. This caused the PR notifications to show up in my "assigned" category and reinforced that I was the lang team member "shepherding" it through.

Additionally, when we manually merge RFCs and PRs after FCP is complete, we usually leave it up to the person who started the FCP.

I think we should automate and formalize this by having triagebot assign the FCP proposer.

@RalfJung
Copy link
Member

RalfJung commented Nov 3, 2023

Additionally, when we manually merge RFCs and PRs after FCP is complete, we usually leave it up to the person who started the FCP.

Do we? I was involved in several FPCs on implementation-heavy PRs. Review is usually done by someone from the compiler team, but it needs t-lang FCP so the FCP proposer is a t-lang member.

I think there are many PRs where assigning the FCP proposer does not make a lot of sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants