Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for Vertex missing in the list of models (frontend) #250

Open
charl3sj opened this issue Jun 20, 2024 · 3 comments
Open

Option for Vertex missing in the list of models (frontend) #250

charl3sj opened this issue Jun 20, 2024 · 3 comments
Assignees

Comments

@charl3sj
Copy link
Collaborator

Describe the bug
We've added support for Gemini chat model via VertexAI in the backend but the corresponding frontend changes are missing.

Expected behavior
User should be allowed to select Vertex and Gemini as a model.

Screenshots
Screenshot 2024-06-20 at 1 02 23 PM

Refer

GoogleVertex = "google_vertex"

Screenshot 2024-06-20 at 1 11 34 PM

@tomlynchRNA
Copy link
Collaborator

@anada10 I remember now, this wasn't made available in frontend yet because vertex only takes credentials from an environment variable. We can't support users providing their own credentials: https://python.langchain.com/v0.2/docs/integrations/chat/google_vertex_ai_palm/#credentials

@anada10
Copy link
Contributor

anada10 commented Jun 20, 2024

@tomlynchRNA what if we use OAUTH for GCP instead?

@tomlynchRNA
Copy link
Collaborator

tomlynchRNA commented Jun 20, 2024

@anada10 I don't think so, it has to be the credentials (like credentials json). They make it pretty clear in their docs/code comments:
image


But good news, I checked the ChatVertexAI source code in Google repo and found this:

https://github.com/langchain-ai/langchain-google/blob/main/libs/vertexai/langchain_google_vertexai/chat_models.py#L648C9-L648C17

So, turns out there is an undocumented option to pass the credentials directly just like other models 😄

We need an update in the webapp and agent-backend to pass credentials, project and location:

image

cc @charl3sj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants