Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make less changes to the ghidra source code #322

Open
sakiodre opened this issue Jun 18, 2023 · 1 comment
Open

Make less changes to the ghidra source code #322

sakiodre opened this issue Jun 18, 2023 · 1 comment

Comments

@sakiodre
Copy link

The commit #fd21d19 changes the OpToken PrintC::comma directly in "printc.cc", but it's possible to modify this in the constructor of RizinPrintC:

RizinPrintC::RizinPrintC(Architecture *g, const string &nm)
	: PrintC(g, nm)
{
	PrintC::comma.print1 = ", ";
}

Also, doesn't that commit conflict with option_space_after_comma in #018d130 ?

@ITAYC0HEN
Copy link
Member

thanks for reaching out @sakiodre :)
Would you mind submitting a PR with your suggested improvement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants